126 lines
4.1 KiB
Plaintext
126 lines
4.1 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "720a8b6d_33b5728d",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 11975
|
|
},
|
|
"writtenOn": "2022-10-26T07:58:00Z",
|
|
"side": 1,
|
|
"message": "Generally looks very good for me. -1 just because of the testing part.",
|
|
"revId": "0c8ccb5191a2ebb93ed7601a161461f283d85b46",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "03da1a37_bd9f52fe",
|
|
"filename": "specs/2023.1/strict-minimum-bandwidth-tunnelled-networks.srt",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 59,
|
|
"author": {
|
|
"id": 11975
|
|
},
|
|
"writtenOn": "2022-10-26T07:58:00Z",
|
|
"side": 1,
|
|
"message": "I don\u0027t think any operator will have clash here but maybe we should consider making this name to be configurable in Neutron to avoid potential problems during upgrade process?",
|
|
"revId": "0c8ccb5191a2ebb93ed7601a161461f283d85b46",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "f320097d_320f3536",
|
|
"filename": "specs/2023.1/strict-minimum-bandwidth-tunnelled-networks.srt",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 59,
|
|
"author": {
|
|
"id": 16688
|
|
},
|
|
"writtenOn": "2022-10-27T10:54:49Z",
|
|
"side": 1,
|
|
"message": "Ok, but it could be a problem if this configuration parameter is changed once the RP is created. In any case, I\u0027ll add a warning in the config variable description.",
|
|
"parentUuid": "03da1a37_bd9f52fe",
|
|
"revId": "0c8ccb5191a2ebb93ed7601a161461f283d85b46",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "06f6d33e_2041d3ee",
|
|
"filename": "specs/2023.1/strict-minimum-bandwidth-tunnelled-networks.srt",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 129,
|
|
"author": {
|
|
"id": 11975
|
|
},
|
|
"writtenOn": "2022-10-26T07:58:00Z",
|
|
"side": 1,
|
|
"message": "+1 for new upgrade check",
|
|
"revId": "0c8ccb5191a2ebb93ed7601a161461f283d85b46",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "29f6ae0a_67982845",
|
|
"filename": "specs/2023.1/strict-minimum-bandwidth-tunnelled-networks.srt",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 129,
|
|
"author": {
|
|
"id": 16688
|
|
},
|
|
"writtenOn": "2022-10-27T10:54:49Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "06f6d33e_2041d3ee",
|
|
"revId": "0c8ccb5191a2ebb93ed7601a161461f283d85b46",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "db6e1ca8_a189d10d",
|
|
"filename": "specs/2023.1/strict-minimum-bandwidth-tunnelled-networks.srt",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 153,
|
|
"author": {
|
|
"id": 11975
|
|
},
|
|
"writtenOn": "2022-10-26T07:58:00Z",
|
|
"side": 1,
|
|
"message": "As we recently discussed internally, can You maybe elaborate more about what kind of tempest tests do You think should be added to test it? Some API tests or scenario test?",
|
|
"revId": "0c8ccb5191a2ebb93ed7601a161461f283d85b46",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "56bcf600_9b4f3570",
|
|
"filename": "specs/2023.1/strict-minimum-bandwidth-tunnelled-networks.srt",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 153,
|
|
"author": {
|
|
"id": 16688
|
|
},
|
|
"writtenOn": "2022-10-27T10:54:49Z",
|
|
"side": 1,
|
|
"message": "The API tests are already covered in tempest.\nInstead of tempest tests, what I should implement is fullstack tests, checking the mech driver agent (OVS, OVN) has correctly reported the requested BW.",
|
|
"parentUuid": "db6e1ca8_a189d10d",
|
|
"revId": "0c8ccb5191a2ebb93ed7601a161461f283d85b46",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |