57 lines
2.2 KiB
Plaintext
57 lines
2.2 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "bf1c3090_17a457c7",
|
|
"filename": "specs/2023.1/strict-minimum-bandwidth-tunnelled-networks.rst",
|
|
"patchSetId": 5
|
|
},
|
|
"lineNbr": 113,
|
|
"author": {
|
|
"id": 9708
|
|
},
|
|
"writtenOn": "2022-11-03T15:11:22Z",
|
|
"side": 1,
|
|
"message": "you can probably drop one of the TUNNELLED words from the trait name.",
|
|
"revId": "ad037f2c5d57565d4f88cf6094f9f9cf9204270f",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "5a6e7861_97475dc9",
|
|
"filename": "specs/2023.1/strict-minimum-bandwidth-tunnelled-networks.rst",
|
|
"patchSetId": 5
|
|
},
|
|
"lineNbr": 113,
|
|
"author": {
|
|
"id": 16688
|
|
},
|
|
"writtenOn": "2022-11-04T10:23:55Z",
|
|
"side": 1,
|
|
"message": "But I need a unique prefix for this trait. I\u0027m building it this way:\nCUSTOM_ + TUNNELLED_ + \u003cRP-name\u003e\n\nOf course, the RP name is \"rp_tunnelled\", this is why we have this duplication. But I prefer that rather than allowing a user to override another trait.",
|
|
"parentUuid": "bf1c3090_17a457c7",
|
|
"revId": "ad037f2c5d57565d4f88cf6094f9f9cf9204270f",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "724989c4_b010fed0",
|
|
"filename": "specs/2023.1/strict-minimum-bandwidth-tunnelled-networks.rst",
|
|
"patchSetId": 5
|
|
},
|
|
"lineNbr": 113,
|
|
"author": {
|
|
"id": 11604
|
|
},
|
|
"writtenOn": "2022-11-04T12:26:12Z",
|
|
"side": 1,
|
|
"message": "why? how do you plan to use this?\n\nthis trait need to be pass form neutorn ot nova before we have selected a host so you cannot depend on the RP name or the tunnelled_network_rp_name parmater unless you sete that to the same value on every host.\n\nso i dont see why this shoudl be dynmaic\n\nit shoudl jsut be CUSTOM_NETWORK_TUNNELED",
|
|
"parentUuid": "5a6e7861_97475dc9",
|
|
"revId": "ad037f2c5d57565d4f88cf6094f9f9cf9204270f",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |