openstack/neutron-specs
Code Issues Proposed changes
43c0e1dcf3
neutron-specs/acb511c1e54758b3457b1a90c910255a0315d4f9
Gerrit User 16688 d6bd2bed01 Update patch set 2 
Patch Set 2:

(3 comments)

Patch-set: 2
Attention: {"person_ident":"Gerrit User 16688 \u003c16688@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_16688\u003e replied on the change"}
2022-10-18 07:19:57 +00:00

564 lines
17 KiB
Plaintext
Raw Blame History

{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "9a7a8271_36b14cff",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 16688
},
"writtenOn": "2022-10-03T16:11:48Z",
"side": 1,
"message": "-1 for visibility only",
"revId": "acb511c1e54758b3457b1a90c910255a0315d4f9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "b716d2b6_c364af6f",
"filename": "specs/2023.1/configurable-default-sg-rules.rst",
"patchSetId": 1
},
"lineNbr": 21,
"author": {
"id": 8313
},
"writtenOn": "2022-09-22T09:57:51Z",
"side": 1,
"message": "nit; these should be # to have numbered list (I think) as you reference them by number below",
"range": {
"startLine": 21,
"startChar": 0,
"endLine": 21,
"endChar": 1
},
"revId": "acb511c1e54758b3457b1a90c910255a0315d4f9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "6a9272f2_45780725",
"filename": "specs/2023.1/configurable-default-sg-rules.rst",
"patchSetId": 1
},
"lineNbr": 21,
"author": {
"id": 16688
},
"writtenOn": "2022-10-03T16:11:48Z",
"side": 1,
"message": "+1",
"parentUuid": "b716d2b6_c364af6f",
"range": {
"startLine": 21,
"startChar": 0,
"endLine": 21,
"endChar": 1
},
"revId": "acb511c1e54758b3457b1a90c910255a0315d4f9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "aa995f3b_66b0fe60",
"filename": "specs/2023.1/configurable-default-sg-rules.rst",
"patchSetId": 1
},
"lineNbr": 21,
"author": {
"id": 11975
},
"writtenOn": "2022-10-05T20:14:10Z",
"side": 1,
"message": "Done",
"parentUuid": "6a9272f2_45780725",
"range": {
"startLine": 21,
"startChar": 0,
"endLine": 21,
"endChar": 1
},
"revId": "acb511c1e54758b3457b1a90c910255a0315d4f9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "e56e1cb0_d79926d8",
"filename": "specs/2023.1/configurable-default-sg-rules.rst",
"patchSetId": 1
},
"lineNbr": 26,
"author": {
"id": 8313
},
"writtenOn": "2022-09-22T09:57:51Z",
"side": 1,
"message": "the so liked remote groups:-)",
"range": {
"startLine": 23,
"startChar": 0,
"endLine": 26,
"endChar": 32
},
"revId": "acb511c1e54758b3457b1a90c910255a0315d4f9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "3ce2acf9_6f5f011d",
"filename": "specs/2023.1/configurable-default-sg-rules.rst",
"patchSetId": 1
},
"lineNbr": 26,
"author": {
"id": 11975
},
"writtenOn": "2022-10-05T20:14:10Z",
"side": 1,
"message": "yeah :)",
"parentUuid": "e56e1cb0_d79926d8",
"range": {
"startLine": 23,
"startChar": 0,
"endLine": 26,
"endChar": 32
},
"revId": "acb511c1e54758b3457b1a90c910255a0315d4f9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "2d64ed23_570e1dfb",
"filename": "specs/2023.1/configurable-default-sg-rules.rst",
"patchSetId": 1
},
"lineNbr": 36,
"author": {
"id": 16688
},
"writtenOn": "2022-10-03T16:11:48Z",
"side": 1,
"message": "nit: \"it is a known fact the the security group rules\"",
"range": {
"startLine": 36,
"startChar": 2,
"endLine": 36,
"endChar": 32
},
"revId": "acb511c1e54758b3457b1a90c910255a0315d4f9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "acf8f615_e5fce55a",
"filename": "specs/2023.1/configurable-default-sg-rules.rst",
"patchSetId": 1
},
"lineNbr": 36,
"author": {
"id": 11975
},
"writtenOn": "2022-10-05T20:14:10Z",
"side": 1,
"message": "Done",
"parentUuid": "2d64ed23_570e1dfb",
"range": {
"startLine": 36,
"startChar": 2,
"endLine": 36,
"endChar": 32
},
"revId": "acb511c1e54758b3457b1a90c910255a0315d4f9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "4110994a_7c213659",
"filename": "specs/2023.1/configurable-default-sg-rules.rst",
"patchSetId": 1
},
"lineNbr": 41,
"author": {
"id": 8313
},
"writtenOn": "2022-09-22T09:57:51Z",
"side": 1,
"message": "nit:easily",
"range": {
"startLine": 41,
"startChar": 60,
"endLine": 41,
"endChar": 64
},
"revId": "acb511c1e54758b3457b1a90c910255a0315d4f9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "949c048d_fa1efd29",
"filename": "specs/2023.1/configurable-default-sg-rules.rst",
"patchSetId": 1
},
"lineNbr": 41,
"author": {
"id": 11975
},
"writtenOn": "2022-10-05T20:14:10Z",
"side": 1,
"message": "Done",
"parentUuid": "4110994a_7c213659",
"range": {
"startLine": 41,
"startChar": 60,
"endLine": 41,
"endChar": 64
},
"revId": "acb511c1e54758b3457b1a90c910255a0315d4f9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "79df8c4b_9722b211",
"filename": "specs/2023.1/configurable-default-sg-rules.rst",
"patchSetId": 1
},
"lineNbr": 51,
"author": {
"id": 8313
},
"writtenOn": "2022-09-22T09:57:51Z",
"side": 1,
"message": "for the given tenant?",
"revId": "acb511c1e54758b3457b1a90c910255a0315d4f9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "c474ee1a_6d70eefc",
"filename": "specs/2023.1/configurable-default-sg-rules.rst",
"patchSetId": 1
},
"lineNbr": 51,
"author": {
"id": 16688
},
"writtenOn": "2022-10-03T16:11:48Z",
"side": 1,
"message": "hmmm, I\u0027m not sure the default SG rules are per project but per cloud.",
"parentUuid": "79df8c4b_9722b211",
"revId": "acb511c1e54758b3457b1a90c910255a0315d4f9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "607752ab_f6dfe0fc",
"filename": "specs/2023.1/configurable-default-sg-rules.rst",
"patchSetId": 1
},
"lineNbr": 51,
"author": {
"id": 11975
},
"writtenOn": "2022-10-05T20:14:10Z",
"side": 1,
"message": "each tenant have got always created automatically security group named \"default\" and that one have 4 rules and uses remote_group_id by default.\nFor any other security group which tenant will create there are always 2 rules added by default (those 2 which allows all egress traffic).",
"parentUuid": "c474ee1a_6d70eefc",
"revId": "acb511c1e54758b3457b1a90c910255a0315d4f9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "9f36262a_03395350",
"filename": "specs/2023.1/configurable-default-sg-rules.rst",
"patchSetId": 1
},
"lineNbr": 51,
"author": {
"id": 8313
},
"writtenOn": "2022-10-12T11:39:42Z",
"side": 1,
"message": "Ack",
"parentUuid": "607752ab_f6dfe0fc",
"revId": "acb511c1e54758b3457b1a90c910255a0315d4f9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "c201f554_1ec931cc",
"filename": "specs/2023.1/configurable-default-sg-rules.rst",
"patchSetId": 1
},
"lineNbr": 52,
"author": {
"id": 8313
},
"writtenOn": "2022-09-22T09:57:51Z",
"side": 1,
"message": "nit: hardcoded",
"range": {
"startLine": 52,
"startChar": 49,
"endLine": 52,
"endChar": 57
},
"revId": "acb511c1e54758b3457b1a90c910255a0315d4f9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "333f5c83_c17726a4",
"filename": "specs/2023.1/configurable-default-sg-rules.rst",
"patchSetId": 1
},
"lineNbr": 52,
"author": {
"id": 16688
},
"writtenOn": "2022-10-03T16:11:48Z",
"side": 1,
"message": "nit: compatibility",
"range": {
"startLine": 52,
"startChar": 17,
"endLine": 52,
"endChar": 30
},
"revId": "acb511c1e54758b3457b1a90c910255a0315d4f9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "b904bc47_1e8a4426",
"filename": "specs/2023.1/configurable-default-sg-rules.rst",
"patchSetId": 1
},
"lineNbr": 52,
"author": {
"id": 11975
},
"writtenOn": "2022-10-05T20:14:10Z",
"side": 1,
"message": "Done",
"parentUuid": "333f5c83_c17726a4",
"range": {
"startLine": 52,
"startChar": 17,
"endLine": 52,
"endChar": 30
},
"revId": "acb511c1e54758b3457b1a90c910255a0315d4f9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "0091ac0d_b9257e3d",
"filename": "specs/2023.1/configurable-default-sg-rules.rst",
"patchSetId": 1
},
"lineNbr": 52,
"author": {
"id": 11975
},
"writtenOn": "2022-10-05T20:14:10Z",
"side": 1,
"message": "Done",
"parentUuid": "c201f554_1ec931cc",
"range": {
"startLine": 52,
"startChar": 49,
"endLine": 52,
"endChar": 57
},
"revId": "acb511c1e54758b3457b1a90c910255a0315d4f9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "04fdd584_5775abb1",
"filename": "specs/2023.1/configurable-default-sg-rules.rst",
"patchSetId": 1
},
"lineNbr": 65,
"author": {
"id": 16688
},
"writtenOn": "2022-10-03T16:11:48Z",
"side": 1,
"message": "Question 1: what are the default default SG rules (note I intentionally used the word \"default\" twice) that a new system will have? None? The 4 existing ones for the default SG?\n\nQuestion 2: for the default security group we create now 4 rules. For a new SG, we always create 2 rules. Will we have two templates, one for the default SG and another one for the default rules to be added in a normal SG?",
"range": {
"startLine": 65,
"startChar": 7,
"endLine": 65,
"endChar": 35
},
"revId": "acb511c1e54758b3457b1a90c910255a0315d4f9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "b75f9f45_f4f2b0f5",
"filename": "specs/2023.1/configurable-default-sg-rules.rst",
"patchSetId": 1
},
"lineNbr": 65,
"author": {
"id": 11975
},
"writtenOn": "2022-10-05T20:14:10Z",
"side": 1,
"message": "\u003e Question 1: what are the default default SG rules (note I intentionally used the word \"default\" twice) that a new system will have? None? The 4 existing ones for the default SG?\n\nBy default we will have those 4 mentioned above added as new \"default default\" rules.\n\n\u003e \n\u003e Question 2: for the default security group we create now 4 rules. For a new SG, we always create 2 rules. Will we have two templates, one for the default SG and another one for the default rules to be added in a normal SG?\n\nKind of, please see L81 and attribute \"used_in_default_security_group\" which will tell if rule should be used in \"default\" SG or only in other security groups.",
"parentUuid": "04fdd584_5775abb1",
"range": {
"startLine": 65,
"startChar": 7,
"endLine": 65,
"endChar": 35
},
"revId": "acb511c1e54758b3457b1a90c910255a0315d4f9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "707f448b_4e69a2b0",
"filename": "specs/2023.1/configurable-default-sg-rules.rst",
"patchSetId": 1
},
"lineNbr": 65,
"author": {
"id": 8313
},
"writtenOn": "2022-10-12T11:39:42Z",
"side": 1,
"message": "thanks, for me looks ok",
"parentUuid": "b75f9f45_f4f2b0f5",
"range": {
"startLine": 65,
"startChar": 7,
"endLine": 65,
"endChar": 35
},
"revId": "acb511c1e54758b3457b1a90c910255a0315d4f9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "c395f575_5e596370",
"filename": "specs/2023.1/configurable-default-sg-rules.rst",
"patchSetId": 1
},
"lineNbr": 65,
"author": {
"id": 16688
},
"writtenOn": "2022-10-18T07:19:57Z",
"side": 1,
"message": "I didn\u0027t see the \"used_in_default_security_group\" field in the JSONs. BTW, I think we need to add it to the DB table.",
"parentUuid": "707f448b_4e69a2b0",
"range": {
"startLine": 65,
"startChar": 7,
"endLine": 65,
"endChar": 35
},
"revId": "acb511c1e54758b3457b1a90c910255a0315d4f9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "3eaa5554_92dc439c",
"filename": "specs/2023.1/configurable-default-sg-rules.rst",
"patchSetId": 1
},
"lineNbr": 229,
"author": {
"id": 8313
},
"writtenOn": "2022-09-22T09:57:51Z",
"side": 1,
"message": "Is PUT planned to be supported?\nWould have strange anyway, would effect for the next created groups only, or such",
"revId": "acb511c1e54758b3457b1a90c910255a0315d4f9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "25cc6daa_f092e6cb",
"filename": "specs/2023.1/configurable-default-sg-rules.rst",
"patchSetId": 1
},
"lineNbr": 229,
"author": {
"id": 16688
},
"writtenOn": "2022-10-03T16:11:48Z",
"side": 1,
"message": "That\u0027s only my opinion, but if we are going to define global resources, like those default SG rules, I would prefer to use statically defined rules. In other words, not to be able to modify them.",
"parentUuid": "3eaa5554_92dc439c",
"revId": "acb511c1e54758b3457b1a90c910255a0315d4f9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "4d409633_73ac24a5",
"filename": "specs/2023.1/configurable-default-sg-rules.rst",
"patchSetId": 1
},
"lineNbr": 229,
"author": {
"id": 8313
},
"writtenOn": "2022-10-05T13:07:01Z",
"side": 1,
"message": "ack. This could be written here or in the docs later",
"parentUuid": "25cc6daa_f092e6cb",
"revId": "acb511c1e54758b3457b1a90c910255a0315d4f9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "c2e9682c_c2c28977",
"filename": "specs/2023.1/configurable-default-sg-rules.rst",
"patchSetId": 1
},
"lineNbr": 229,
"author": {
"id": 11975
},
"writtenOn": "2022-10-05T20:14:10Z",
"side": 1,
"message": "I didn\u0027t plan to support PUT as it\u0027s also not supported by Security group rules API currently.",
"parentUuid": "4d409633_73ac24a5",
"revId": "acb511c1e54758b3457b1a90c910255a0315d4f9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}
View Git Blame Copy Permalink