openstack
/
neutron-specs
Code Issues Proposed changes
neutron-specs/bb25ea336f9eb1ba5c3970b2e50...

820 lines
22 KiB
Plaintext
Raw Blame History

{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "dcc28fa0_13bc8867",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 16688
},
"writtenOn": "2022-12-21T12:38:41Z",
"side": 1,
"message": "Some nits and missing details. But the feature and the spec look good!",
"revId": "bb25ea336f9eb1ba5c3970b2e502dced32094da3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "67863efb_e72b97f8",
"filename": "specs/2023.1/ovn-ipv6-dvr.rst",
"patchSetId": 1
},
"lineNbr": 15,
"author": {
"id": 16688
},
"writtenOn": "2022-12-21T12:38:41Z",
"side": 1,
"message": "For IPv4 FIP addresses. We are DNATing FIP addresses, not SNATing fixed IP addresses.\n\nBut this spec, if I\u0027m not wrong, is proposing the DVR SNATing of IPv6 addresses (something expected because we don\u0027t have FIP for IPv6).\n\nEdit: actually you are mentioning IPv4 FIP in later comments.",
"range": {
"startLine": 14,
"startChar": 73,
"endLine": 15,
"endChar": 9
},
"revId": "bb25ea336f9eb1ba5c3970b2e502dced32094da3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "ead7c15a_645c61e1",
"filename": "specs/2023.1/ovn-ipv6-dvr.rst",
"patchSetId": 1
},
"lineNbr": 15,
"author": {
"id": 35432
},
"writtenOn": "2022-12-26T16:38:36Z",
"side": 1,
"message": "Done",
"parentUuid": "67863efb_e72b97f8",
"range": {
"startLine": 14,
"startChar": 73,
"endLine": 15,
"endChar": 9
},
"revId": "bb25ea336f9eb1ba5c3970b2e502dced32094da3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "2ce6eada_1ba00fa3",
"filename": "specs/2023.1/ovn-ipv6-dvr.rst",
"patchSetId": 1
},
"lineNbr": 29,
"author": {
"id": 16688
},
"writtenOn": "2022-12-21T12:38:41Z",
"side": 1,
"message": "nit: in the specs, let\u0027s use the full word \"gateway\"",
"range": {
"startLine": 29,
"startChar": 46,
"endLine": 29,
"endChar": 48
},
"revId": "bb25ea336f9eb1ba5c3970b2e502dced32094da3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "34025368_117996bd",
"filename": "specs/2023.1/ovn-ipv6-dvr.rst",
"patchSetId": 1
},
"lineNbr": 29,
"author": {
"id": 35432
},
"writtenOn": "2022-12-26T16:38:36Z",
"side": 1,
"message": "Done",
"parentUuid": "2ce6eada_1ba00fa3",
"range": {
"startLine": 29,
"startChar": 46,
"endLine": 29,
"endChar": 48
},
"revId": "bb25ea336f9eb1ba5c3970b2e502dced32094da3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "5218c353_883df644",
"filename": "specs/2023.1/ovn-ipv6-dvr.rst",
"patchSetId": 1
},
"lineNbr": 36,
"author": {
"id": 16688
},
"writtenOn": "2022-12-21T12:38:41Z",
"side": 1,
"message": "CI is failing because of these \"red blocks\". You need to remove the trailing spaces",
"range": {
"startLine": 36,
"startChar": 69,
"endLine": 36,
"endChar": 70
},
"revId": "bb25ea336f9eb1ba5c3970b2e502dced32094da3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "9514a502_8a14eb70",
"filename": "specs/2023.1/ovn-ipv6-dvr.rst",
"patchSetId": 1
},
"lineNbr": 36,
"author": {
"id": 35432
},
"writtenOn": "2022-12-26T16:38:36Z",
"side": 1,
"message": "Done",
"parentUuid": "5218c353_883df644",
"range": {
"startLine": 36,
"startChar": 69,
"endLine": 36,
"endChar": 70
},
"revId": "bb25ea336f9eb1ba5c3970b2e502dced32094da3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "689dbc70_0209a737",
"filename": "specs/2023.1/ovn-ipv6-dvr.rst",
"patchSetId": 1
},
"lineNbr": 63,
"author": {
"id": 16688
},
"writtenOn": "2022-12-21T12:38:41Z",
"side": 1,
"message": "super nit: maybe better to print that as code\n\n .. code:\n\n - E/W PATH:\n Compute Node VM \u003c-\u003e OVS br-int \u003c-\u003e br-provider \u003c-\u003e external-bridge-mapping\n \u003c-\u003e FRR \u003c-\u003e BGP EVPN type2 \u003c-\u003e E/W spine/leaf \u003c-\u003e [reverse flow to VM]\n - N/S PATH:\n Compute Node VM \u003c-\u003e OVS br-int \u003c-\u003e br-provider \u003c-\u003e external-bridge-mapping\n \u003c-\u003e FRR \u003c-\u003e BGP EVPN type2 \u003c-\u003e N/S Border Leaf \u003c-\u003e external network",
"range": {
"startLine": 58,
"startChar": 0,
"endLine": 63,
"endChar": 71
},
"revId": "bb25ea336f9eb1ba5c3970b2e502dced32094da3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "7565c414_e900208b",
"filename": "specs/2023.1/ovn-ipv6-dvr.rst",
"patchSetId": 1
},
"lineNbr": 63,
"author": {
"id": 35432
},
"writtenOn": "2022-12-26T16:38:36Z",
"side": 1,
"message": "Done",
"parentUuid": "689dbc70_0209a737",
"range": {
"startLine": 58,
"startChar": 0,
"endLine": 63,
"endChar": 71
},
"revId": "bb25ea336f9eb1ba5c3970b2e502dced32094da3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "7033e715_22695a24",
"filename": "specs/2023.1/ovn-ipv6-dvr.rst",
"patchSetId": 1
},
"lineNbr": 69,
"author": {
"id": 16688
},
"writtenOn": "2022-12-21T12:38:41Z",
"side": 1,
"message": "In capital letters OVN/OVS (and I would mention OVN only, OVS is just the backend service)",
"range": {
"startLine": 69,
"startChar": 59,
"endLine": 69,
"endChar": 66
},
"revId": "bb25ea336f9eb1ba5c3970b2e502dced32094da3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "18f3866d_8f006bb5",
"filename": "specs/2023.1/ovn-ipv6-dvr.rst",
"patchSetId": 1
},
"lineNbr": 69,
"author": {
"id": 35432
},
"writtenOn": "2022-12-26T16:38:36Z",
"side": 1,
"message": "Done",
"parentUuid": "7033e715_22695a24",
"range": {
"startLine": 69,
"startChar": 59,
"endLine": 69,
"endChar": 66
},
"revId": "bb25ea336f9eb1ba5c3970b2e502dced32094da3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "2d343be8_effc0742",
"filename": "specs/2023.1/ovn-ipv6-dvr.rst",
"patchSetId": 1
},
"lineNbr": 77,
"author": {
"id": 16688
},
"writtenOn": "2022-12-21T12:38:41Z",
"side": 1,
"message": "print as code",
"range": {
"startLine": 77,
"startChar": 0,
"endLine": 77,
"endChar": 36
},
"revId": "bb25ea336f9eb1ba5c3970b2e502dced32094da3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "e4259f26_5b55eadf",
"filename": "specs/2023.1/ovn-ipv6-dvr.rst",
"patchSetId": 1
},
"lineNbr": 77,
"author": {
"id": 35432
},
"writtenOn": "2022-12-26T16:38:36Z",
"side": 1,
"message": "Done",
"parentUuid": "2d343be8_effc0742",
"range": {
"startLine": 77,
"startChar": 0,
"endLine": 77,
"endChar": 36
},
"revId": "bb25ea336f9eb1ba5c3970b2e502dced32094da3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "6186b1f5_2c1f66fa",
"filename": "specs/2023.1/ovn-ipv6-dvr.rst",
"patchSetId": 1
},
"lineNbr": 83,
"author": {
"id": 16688
},
"writtenOn": "2022-12-21T12:38:41Z",
"side": 1,
"message": "this should have the same lenght as the title (check the CI warnings)\n\n OVN/OVS Impact\n --------------",
"range": {
"startLine": 83,
"startChar": 0,
"endLine": 83,
"endChar": 19
},
"revId": "bb25ea336f9eb1ba5c3970b2e502dced32094da3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "33aa47c3_7a307975",
"filename": "specs/2023.1/ovn-ipv6-dvr.rst",
"patchSetId": 1
},
"lineNbr": 83,
"author": {
"id": 35432
},
"writtenOn": "2022-12-26T16:38:36Z",
"side": 1,
"message": "Done",
"parentUuid": "6186b1f5_2c1f66fa",
"range": {
"startLine": 83,
"startChar": 0,
"endLine": 83,
"endChar": 19
},
"revId": "bb25ea336f9eb1ba5c3970b2e502dced32094da3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "7b422c44_56f6e5bd",
"filename": "specs/2023.1/ovn-ipv6-dvr.rst",
"patchSetId": 1
},
"lineNbr": 85,
"author": {
"id": 16688
},
"writtenOn": "2022-12-21T12:38:41Z",
"side": 1,
"message": "Why this indentation? There is no need",
"range": {
"startLine": 85,
"startChar": 0,
"endLine": 85,
"endChar": 2
},
"revId": "bb25ea336f9eb1ba5c3970b2e502dced32094da3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "c79d163a_0ad78321",
"filename": "specs/2023.1/ovn-ipv6-dvr.rst",
"patchSetId": 1
},
"lineNbr": 85,
"author": {
"id": 35432
},
"writtenOn": "2022-12-26T16:38:36Z",
"side": 1,
"message": "Done",
"parentUuid": "7b422c44_56f6e5bd",
"range": {
"startLine": 85,
"startChar": 0,
"endLine": 85,
"endChar": 2
},
"revId": "bb25ea336f9eb1ba5c3970b2e502dced32094da3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "c2f8dbd0_8dcfc31a",
"filename": "specs/2023.1/ovn-ipv6-dvr.rst",
"patchSetId": 1
},
"lineNbr": 97,
"author": {
"id": 16688
},
"writtenOn": "2022-12-21T12:38:41Z",
"side": 1,
"message": "same here: print that as code",
"range": {
"startLine": 92,
"startChar": 4,
"endLine": 97,
"endChar": 32
},
"revId": "bb25ea336f9eb1ba5c3970b2e502dced32094da3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "5791dd90_ea148e77",
"filename": "specs/2023.1/ovn-ipv6-dvr.rst",
"patchSetId": 1
},
"lineNbr": 97,
"author": {
"id": 35432
},
"writtenOn": "2022-12-26T16:38:36Z",
"side": 1,
"message": "Done",
"parentUuid": "c2f8dbd0_8dcfc31a",
"range": {
"startLine": 92,
"startChar": 4,
"endLine": 97,
"endChar": 32
},
"revId": "bb25ea336f9eb1ba5c3970b2e502dced32094da3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "4d1be58e_2fc733e0",
"filename": "specs/2023.1/ovn-ipv6-dvr.rst",
"patchSetId": 1
},
"lineNbr": 108,
"author": {
"id": 16688
},
"writtenOn": "2022-12-21T12:38:41Z",
"side": 1,
"message": "Geneve",
"range": {
"startLine": 108,
"startChar": 24,
"endLine": 108,
"endChar": 30
},
"revId": "bb25ea336f9eb1ba5c3970b2e502dced32094da3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "7bf78c08_65dc94d9",
"filename": "specs/2023.1/ovn-ipv6-dvr.rst",
"patchSetId": 1
},
"lineNbr": 108,
"author": {
"id": 35432
},
"writtenOn": "2022-12-26T16:38:36Z",
"side": 1,
"message": "Done",
"parentUuid": "4d1be58e_2fc733e0",
"range": {
"startLine": 108,
"startChar": 24,
"endLine": 108,
"endChar": 30
},
"revId": "bb25ea336f9eb1ba5c3970b2e502dced32094da3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "0c61fade_fd538894",
"filename": "specs/2023.1/ovn-ipv6-dvr.rst",
"patchSetId": 1
},
"lineNbr": 111,
"author": {
"id": 16688
},
"writtenOn": "2022-12-21T12:38:41Z",
"side": 1,
"message": "same here: the lenght",
"range": {
"startLine": 111,
"startChar": 0,
"endLine": 111,
"endChar": 1
},
"revId": "bb25ea336f9eb1ba5c3970b2e502dced32094da3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "b747d3e7_165f5154",
"filename": "specs/2023.1/ovn-ipv6-dvr.rst",
"patchSetId": 1
},
"lineNbr": 111,
"author": {
"id": 35432
},
"writtenOn": "2022-12-26T16:38:36Z",
"side": 1,
"message": "Done",
"parentUuid": "0c61fade_fd538894",
"range": {
"startLine": 111,
"startChar": 0,
"endLine": 111,
"endChar": 1
},
"revId": "bb25ea336f9eb1ba5c3970b2e502dced32094da3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "3caecf2f_2175589a",
"filename": "specs/2023.1/ovn-ipv6-dvr.rst",
"patchSetId": 1
},
"lineNbr": 113,
"author": {
"id": 16688
},
"writtenOn": "2022-12-21T12:38:41Z",
"side": 1,
"message": "IPv4",
"range": {
"startLine": 113,
"startChar": 24,
"endLine": 113,
"endChar": 28
},
"revId": "bb25ea336f9eb1ba5c3970b2e502dced32094da3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "e7a6db54_8d2bbbb5",
"filename": "specs/2023.1/ovn-ipv6-dvr.rst",
"patchSetId": 1
},
"lineNbr": 113,
"author": {
"id": 16688
},
"writtenOn": "2022-12-21T12:38:41Z",
"side": 1,
"message": "No indentation needed.",
"range": {
"startLine": 113,
"startChar": 0,
"endLine": 113,
"endChar": 2
},
"revId": "bb25ea336f9eb1ba5c3970b2e502dced32094da3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "f9e439f5_1c853fb6",
"filename": "specs/2023.1/ovn-ipv6-dvr.rst",
"patchSetId": 1
},
"lineNbr": 113,
"author": {
"id": 35432
},
"writtenOn": "2022-12-26T16:38:36Z",
"side": 1,
"message": "Done",
"parentUuid": "e7a6db54_8d2bbbb5",
"range": {
"startLine": 113,
"startChar": 0,
"endLine": 113,
"endChar": 2
},
"revId": "bb25ea336f9eb1ba5c3970b2e502dced32094da3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "685c2ec0_5267bb79",
"filename": "specs/2023.1/ovn-ipv6-dvr.rst",
"patchSetId": 1
},
"lineNbr": 113,
"author": {
"id": 35432
},
"writtenOn": "2022-12-26T16:38:36Z",
"side": 1,
"message": "Done",
"parentUuid": "3caecf2f_2175589a",
"range": {
"startLine": 113,
"startChar": 24,
"endLine": 113,
"endChar": 28
},
"revId": "bb25ea336f9eb1ba5c3970b2e502dced32094da3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "10229e4f_820c4c6d",
"filename": "specs/2023.1/ovn-ipv6-dvr.rst",
"patchSetId": 1
},
"lineNbr": 138,
"author": {
"id": 16688
},
"writtenOn": "2022-12-21T12:38:41Z",
"side": 1,
"message": "print as code",
"range": {
"startLine": 130,
"startChar": 2,
"endLine": 138,
"endChar": 3
},
"revId": "bb25ea336f9eb1ba5c3970b2e502dced32094da3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "cb24d243_1e5f195c",
"filename": "specs/2023.1/ovn-ipv6-dvr.rst",
"patchSetId": 1
},
"lineNbr": 138,
"author": {
"id": 35432
},
"writtenOn": "2022-12-26T16:38:36Z",
"side": 1,
"message": "Done",
"parentUuid": "10229e4f_820c4c6d",
"range": {
"startLine": 130,
"startChar": 2,
"endLine": 138,
"endChar": 3
},
"revId": "bb25ea336f9eb1ba5c3970b2e502dced32094da3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "4677cc2f_a93ea985",
"filename": "specs/2023.1/ovn-ipv6-dvr.rst",
"patchSetId": 1
},
"lineNbr": 146,
"author": {
"id": 16688
},
"writtenOn": "2022-12-21T12:38:41Z",
"side": 1,
"message": "1) When/where those rules are added/removed?\n2) If the port is detached from the router (the subnet), we should remove these rules too.",
"range": {
"startLine": 146,
"startChar": 2,
"endLine": 146,
"endChar": 3
},
"revId": "bb25ea336f9eb1ba5c3970b2e502dced32094da3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "2cdd5bd1_44c977bc",
"filename": "specs/2023.1/ovn-ipv6-dvr.rst",
"patchSetId": 1
},
"lineNbr": 146,
"author": {
"id": 35432
},
"writtenOn": "2022-12-26T16:38:36Z",
"side": 1,
"message": "Please see the answers in the \u0027Neutron Impact\u0027 and \u0027IPv6 DVR events\u0027. Let me know if you have any questions.",
"parentUuid": "4677cc2f_a93ea985",
"range": {
"startLine": 146,
"startChar": 2,
"endLine": 146,
"endChar": 3
},
"revId": "bb25ea336f9eb1ba5c3970b2e502dced32094da3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "b1f91ddd_379eb430",
"filename": "specs/2023.1/ovn-ipv6-dvr.rst",
"patchSetId": 1
},
"lineNbr": 155,
"author": {
"id": 16688
},
"writtenOn": "2022-12-21T12:38:41Z",
"side": 1,
"message": "Where is this information stored? What OVN register?",
"range": {
"startLine": 154,
"startChar": 0,
"endLine": 155,
"endChar": 70
},
"revId": "bb25ea336f9eb1ba5c3970b2e502dced32094da3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "d2ad0457_17c8435e",
"filename": "specs/2023.1/ovn-ipv6-dvr.rst",
"patchSetId": 1
},
"lineNbr": 155,
"author": {
"id": 35432
},
"writtenOn": "2022-12-26T16:38:36Z",
"side": 1,
"message": "Done",
"parentUuid": "b1f91ddd_379eb430",
"range": {
"startLine": 154,
"startChar": 0,
"endLine": 155,
"endChar": 70
},
"revId": "bb25ea336f9eb1ba5c3970b2e502dced32094da3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "3481c8ef_47adcd2a",
"filename": "specs/2023.1/ovn-ipv6-dvr.rst",
"patchSetId": 1
},
"lineNbr": 189,
"author": {
"id": 16688
},
"writtenOn": "2022-12-21T12:38:41Z",
"side": 1,
"message": "You also need to add the testing and documentation section.",
"range": {
"startLine": 189,
"startChar": 0,
"endLine": 189,
"endChar": 1
},
"revId": "bb25ea336f9eb1ba5c3970b2e502dced32094da3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "5ebef88c_940af778",
"filename": "specs/2023.1/ovn-ipv6-dvr.rst",
"patchSetId": 1
},
"lineNbr": 189,
"author": {
"id": 35432
},
"writtenOn": "2022-12-26T16:38:36Z",
"side": 1,
"message": "Done",
"parentUuid": "3481c8ef_47adcd2a",
"range": {
"startLine": 189,
"startChar": 0,
"endLine": 189,
"endChar": 1
},
"revId": "bb25ea336f9eb1ba5c3970b2e502dced32094da3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}
View Git Blame Copy Permalink