125 lines
5.2 KiB
Plaintext
125 lines
5.2 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "23fff4e2_697ac1a9",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 12
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 4694
|
|
},
|
|
"writtenOn": "2022-07-29T21:29:45Z",
|
|
"side": 1,
|
|
"message": "Given the path that the conversation about supporting this use case has taken on the Nova side, we should put this spec on hold, with the understanding that the most likely scenario is that it will not be needed. Please see my comments in-line",
|
|
"revId": "e92e1872a59ea50ecc7c2ed535bdfdfb08595f2f",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "5e0e5d9c_63dd5b17",
|
|
"filename": "specs/zed/support-dns-subdomains-at-a-network-level.rst",
|
|
"patchSetId": 12
|
|
},
|
|
"lineNbr": 17,
|
|
"author": {
|
|
"id": 11975
|
|
},
|
|
"writtenOn": "2022-07-20T14:46:41Z",
|
|
"side": 1,
|
|
"message": "what about https://review.opendev.org/c/openstack/neutron-specs/+/687458/9/specs/ussuri/allow-user-to-create-default-record-on-port-creation-from-shared-network.rst - this is already implemented as an ML2 extension, so operator can use some \"keywords\" in the specified domain name and users will have different domains used for their ports.\nWould it fit into use case described here?",
|
|
"revId": "e92e1872a59ea50ecc7c2ed535bdfdfb08595f2f",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "c32e355f_8c2a398b",
|
|
"filename": "specs/zed/support-dns-subdomains-at-a-network-level.rst",
|
|
"patchSetId": 12
|
|
},
|
|
"lineNbr": 58,
|
|
"author": {
|
|
"id": 8313
|
|
},
|
|
"writtenOn": "2022-07-14T13:05:13Z",
|
|
"side": 1,
|
|
"message": "nit: useless line break",
|
|
"revId": "e92e1872a59ea50ecc7c2ed535bdfdfb08595f2f",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "b9718915_cb78d6a2",
|
|
"filename": "specs/zed/support-dns-subdomains-at-a-network-level.rst",
|
|
"patchSetId": 12
|
|
},
|
|
"lineNbr": 70,
|
|
"author": {
|
|
"id": 4694
|
|
},
|
|
"writtenOn": "2022-07-29T21:29:45Z",
|
|
"side": 1,
|
|
"message": "We have been working on this spec under the explicit assumption (see lines highlighted) that it will be complemented on the Nova side by this spec: https://review.opendev.org/c/openstack/nova-specs/+/840974. However, recently the Nova team has decided to address the use case in a manner that doesn\u0027t require any cooperation from Neutron. They came up with a spec (https://review.opendev.org/c/openstack/nova-specs/+/849765) that went from original submission to approval in matter of a five days and then they reverted it, due to opposition within their core team. Currently, they are planning to discuss again how to address the use case in the Antelope cycle with this spec: https://review.opendev.org/c/openstack/nova-specs/+/850352. Still, the proposed alternatives don\u0027t require cooperation from Neutron.\n\nAs a consequence, we should put this spec on hold. Let\u0027s watch the conversation on the Nova side during the Antelope cycle, in the unlikely case that something might be needed from Neutron.",
|
|
"range": {
|
|
"startLine": 67,
|
|
"startChar": 5,
|
|
"endLine": 70,
|
|
"endChar": 20
|
|
},
|
|
"revId": "e92e1872a59ea50ecc7c2ed535bdfdfb08595f2f",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "c53deb39_cc7e87ff",
|
|
"filename": "specs/zed/support-dns-subdomains-at-a-network-level.rst",
|
|
"patchSetId": 12
|
|
},
|
|
"lineNbr": 70,
|
|
"author": {
|
|
"id": 8864
|
|
},
|
|
"writtenOn": "2022-08-25T00:31:01Z",
|
|
"side": 1,
|
|
"message": "I disagree. Exposing the network\u0027s dns_domain in DHCP is completely independent of Nova, and only relies on Nova\u0027s metadata to the extend that we\u0027d like to give cloud-init the same information as DHCP to avoid cloud-init clobbering the DHCP-derives dns_domain. For guests without cloud-init, or guests where cloud-init\u0027s configuration disabled dns_domain management, this spec is still very useful, and can stand on its own.",
|
|
"parentUuid": "b9718915_cb78d6a2",
|
|
"range": {
|
|
"startLine": 67,
|
|
"startChar": 5,
|
|
"endLine": 70,
|
|
"endChar": 20
|
|
},
|
|
"revId": "e92e1872a59ea50ecc7c2ed535bdfdfb08595f2f",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "5c049630_c6413dae",
|
|
"filename": "specs/zed/support-dns-subdomains-at-a-network-level.rst",
|
|
"patchSetId": 12
|
|
},
|
|
"lineNbr": 114,
|
|
"author": {
|
|
"id": 8313
|
|
},
|
|
"writtenOn": "2022-07-14T13:05:13Z",
|
|
"side": 1,
|
|
"message": "it:the ?",
|
|
"range": {
|
|
"startLine": 114,
|
|
"startChar": 20,
|
|
"endLine": 114,
|
|
"endChar": 21
|
|
},
|
|
"revId": "e92e1872a59ea50ecc7c2ed535bdfdfb08595f2f",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |