openstack
/
neutron-specs
Code Issues Proposed changes
neutron-specs/163edccabb9a18511748f6de3cd...

215 lines
7.2 KiB
Plaintext
Raw Blame History

{
"comments": [
{
"key": {
"uuid": "AAAAXH//vlI\u003d",
"filename": "specs/ipv6-provider-nets-slaac.rst",
"patchSetId": 2
},
"lineNbr": 3,
"author": {
"id": 261
},
"writtenOn": "2014-04-17T21:39:26Z",
"side": 1,
"message": "This blueprint has a dependency - the API attributes for IPv6 should be unhidden.",
"revId": "163edccabb9a18511748f6de3cde87a4e7d25fef",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAAXH//plE\u003d",
"filename": "specs/ipv6-provider-nets-slaac.rst",
"patchSetId": 2
},
"lineNbr": 3,
"author": {
"id": 4656
},
"writtenOn": "2014-04-18T14:27:57Z",
"side": 1,
"message": "If I\u0027m not mistaken, that commit was merged a couple days ago?",
"parentUuid": "AAAAXH//vlI\u003d",
"revId": "163edccabb9a18511748f6de3cde87a4e7d25fef",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAAXH//3Hk\u003d",
"filename": "specs/ipv6-provider-nets-slaac.rst",
"patchSetId": 2
},
"lineNbr": 12,
"author": {
"id": 105
},
"writtenOn": "2014-04-16T21:18:22Z",
"side": 1,
"message": "Duplicate text here. This block is the same as the one above.",
"revId": "163edccabb9a18511748f6de3cde87a4e7d25fef",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAAXH//plA\u003d",
"filename": "specs/ipv6-provider-nets-slaac.rst",
"patchSetId": 2
},
"lineNbr": 12,
"author": {
"id": 4656
},
"writtenOn": "2014-04-18T14:27:57Z",
"side": 1,
"message": "Done",
"parentUuid": "AAAAXH//3Hk\u003d",
"revId": "163edccabb9a18511748f6de3cde87a4e7d25fef",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAAXH//3II\u003d",
"filename": "specs/ipv6-provider-nets-slaac.rst",
"patchSetId": 2
},
"lineNbr": 33,
"author": {
"id": 105
},
"writtenOn": "2014-04-16T21:18:22Z",
"side": 1,
"message": "Nit: whitespace.",
"revId": "163edccabb9a18511748f6de3cde87a4e7d25fef",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAAXH//uew\u003d",
"filename": "specs/ipv6-provider-nets-slaac.rst",
"patchSetId": 2
},
"lineNbr": 33,
"author": {
"id": 261
},
"writtenOn": "2014-04-17T21:39:26Z",
"side": 1,
"message": "beyond the whitespace (for which I would not enforce a fix in specs even if it displays the ugly red box!) I think that there is something else about the implementation that need to be considered.\n\nIt seems that the requirement is that it should be possible to have provider networks which implicitly use SLAAC.\nIn this case ipv6_address_mode will be set to slaac no matter what the user specifies. Also, it might be worth considering (and documenting) the ability of returning a 409 if either ipv6 attributes are set on SLAAC networks.\n\nOn the other hand, if the user can choose an alternative address mode even on a SLAAC provider network, then this approach might be fine.",
"parentUuid": "AAAAXH//3II\u003d",
"revId": "163edccabb9a18511748f6de3cde87a4e7d25fef",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAAXH//pjM\u003d",
"filename": "specs/ipv6-provider-nets-slaac.rst",
"patchSetId": 2
},
"lineNbr": 33,
"author": {
"id": 4656
},
"writtenOn": "2014-04-18T14:27:57Z",
"side": 1,
"message": "It may be possible to specify another address mode - although the trouble will be in getting Neutron to agree with whatever upstream DHCPv6 is, when it comes to IP address allocations.\n\nFor now, I\u0027m just keeping this spec focused on what is being deployed at Comcast.",
"parentUuid": "AAAAXH//uew\u003d",
"revId": "163edccabb9a18511748f6de3cde87a4e7d25fef",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAAXH//288\u003d",
"filename": "specs/ipv6-provider-nets-slaac.rst",
"patchSetId": 2
},
"lineNbr": 36,
"author": {
"id": 6524
},
"writtenOn": "2014-04-16T21:53:00Z",
"side": 1,
"message": "If you run \u0027tox -e docs\u0027 you will get sphinx warnings on this bullet list. The continuation lines must be indented.",
"revId": "163edccabb9a18511748f6de3cde87a4e7d25fef",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAAXH//25k\u003d",
"filename": "specs/ipv6-provider-nets-slaac.rst",
"patchSetId": 2
},
"lineNbr": 36,
"author": {
"id": 105
},
"writtenOn": "2014-04-16T22:04:01Z",
"side": 1,
"message": "I have a patchset out [1] which will enable this type of checking during the jenkins run for neutron-specs, so hopefully once that lands we\u0027ll catch these errors automatically.\n\n[1] https://review.openstack.org/#/c/88069/",
"parentUuid": "AAAAXH//288\u003d",
"revId": "163edccabb9a18511748f6de3cde87a4e7d25fef",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAAXH//vqY\u003d",
"filename": "specs/ipv6-provider-nets-slaac.rst",
"patchSetId": 2
},
"lineNbr": 36,
"author": {
"id": 261
},
"writtenOn": "2014-04-17T21:39:26Z",
"side": 1,
"message": "Honestly, I don\u0027t think this is an error, unless the result of sphinx build is unreadable.",
"parentUuid": "AAAAXH//25k\u003d",
"revId": "163edccabb9a18511748f6de3cde87a4e7d25fef",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAAXH//vqE\u003d",
"filename": "specs/ipv6-provider-nets-slaac.rst",
"patchSetId": 2
},
"lineNbr": 52,
"author": {
"id": 261
},
"writtenOn": "2014-04-17T21:39:26Z",
"side": 1,
"message": "what would be your strategy for this?",
"revId": "163edccabb9a18511748f6de3cde87a4e7d25fef",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAAXH//pkg\u003d",
"filename": "specs/ipv6-provider-nets-slaac.rst",
"patchSetId": 2
},
"lineNbr": 52,
"author": {
"id": 4656
},
"writtenOn": "2014-04-18T14:27:57Z",
"side": 1,
"message": "Couple new checks in the DHCP agent -\n\nhttps://review.openstack.org/#/c/64578/",
"parentUuid": "AAAAXH//vqE\u003d",
"revId": "163edccabb9a18511748f6de3cde87a4e7d25fef",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}
View Git Blame Copy Permalink