115 lines
3.4 KiB
Plaintext
115 lines
3.4 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "41e6d7d1_3ca09646",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 15554
|
|
},
|
|
"writtenOn": "2023-11-15T13:11:26Z",
|
|
"side": 1,
|
|
"message": "I agree that this can be helpful to work around our dependency on the MQ. I just left two nits, not meant to block this spec in any way.",
|
|
"revId": "a6a7ff31fad0d860625da995c53f77bfe8b7cb6f",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "29cfff46_a06eb2c1",
|
|
"filename": "specs/2024.1/l3bgp-resilient-peer-sessions.rst",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 26,
|
|
"author": {
|
|
"id": 1131
|
|
},
|
|
"writtenOn": "2023-11-10T14:43:15Z",
|
|
"side": 1,
|
|
"message": "s/BGP",
|
|
"range": {
|
|
"startLine": 26,
|
|
"startChar": 39,
|
|
"endLine": 26,
|
|
"endChar": 42
|
|
},
|
|
"revId": "a6a7ff31fad0d860625da995c53f77bfe8b7cb6f",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "def0db53_b927b350",
|
|
"filename": "specs/2024.1/l3bgp-resilient-peer-sessions.rst",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 26,
|
|
"author": {
|
|
"id": 35432
|
|
},
|
|
"writtenOn": "2023-11-24T19:58:15Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "29cfff46_a06eb2c1",
|
|
"range": {
|
|
"startLine": 26,
|
|
"startChar": 39,
|
|
"endLine": 26,
|
|
"endChar": 42
|
|
},
|
|
"revId": "a6a7ff31fad0d860625da995c53f77bfe8b7cb6f",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "0f264f47_88693c1d",
|
|
"filename": "specs/2024.1/l3bgp-resilient-peer-sessions.rst",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 152,
|
|
"author": {
|
|
"id": 15554
|
|
},
|
|
"writtenOn": "2023-11-15T13:11:26Z",
|
|
"side": 1,
|
|
"message": "Two notes on this:\n\n1) When implementing this please make sure that this internal state is observable through log messages even on the default log level.\n\n2) Maybe consider a different name like \"speaker_cache_stale \u003d True/False\" or \"speaker_cache_out_of_sync\". I\u0027m hoping this makes it more self-explanatory what this state is.",
|
|
"range": {
|
|
"startLine": 152,
|
|
"startChar": 48,
|
|
"endLine": 152,
|
|
"endChar": 67
|
|
},
|
|
"revId": "a6a7ff31fad0d860625da995c53f77bfe8b7cb6f",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "44a819ac_8fc7cc0c",
|
|
"filename": "specs/2024.1/l3bgp-resilient-peer-sessions.rst",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 152,
|
|
"author": {
|
|
"id": 35432
|
|
},
|
|
"writtenOn": "2023-11-24T19:58:15Z",
|
|
"side": 1,
|
|
"message": "Thanks for the review Bence.\n\n1) Sure, I\u0027ll implement it this way.\n\n2) It makes sense to me, I\u0027ll change it as suggested. Thanks",
|
|
"parentUuid": "0f264f47_88693c1d",
|
|
"range": {
|
|
"startLine": 152,
|
|
"startChar": 48,
|
|
"endLine": 152,
|
|
"endChar": 67
|
|
},
|
|
"revId": "a6a7ff31fad0d860625da995c53f77bfe8b7cb6f",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |