423 lines
14 KiB
Plaintext
423 lines
14 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "AAAAXH//wzQ\u003d",
|
|
"filename": "specs/juno/fsl-sdn-os-mech-driver.rst",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 13,
|
|
"author": {
|
|
"id": 105
|
|
},
|
|
"writtenOn": "2014-04-17T18:42:10Z",
|
|
"side": 1,
|
|
"message": "Nit: There is whitespace in various places here, can you please clean that up?",
|
|
"revId": "31ffc682f64125f8639ae6d59632b4693779b590",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "AAAAXH//tm0\u003d",
|
|
"filename": "specs/juno/fsl-sdn-os-mech-driver.rst",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 13,
|
|
"author": {
|
|
"id": 8645
|
|
},
|
|
"writtenOn": "2014-04-18T01:33:57Z",
|
|
"side": 1,
|
|
"message": "I will remove the spaces and upload the new draft",
|
|
"parentUuid": "AAAAXH//wzQ\u003d",
|
|
"revId": "31ffc682f64125f8639ae6d59632b4693779b590",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "AAAAXH//wQc\u003d",
|
|
"filename": "specs/juno/fsl-sdn-os-mech-driver.rst",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 20,
|
|
"author": {
|
|
"id": 2592
|
|
},
|
|
"writtenOn": "2014-04-17T17:36:09Z",
|
|
"side": 1,
|
|
"message": "This needs to be cleaned up.",
|
|
"revId": "31ffc682f64125f8639ae6d59632b4693779b590",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "AAAAXH//vyQ\u003d",
|
|
"filename": "specs/juno/fsl-sdn-os-mech-driver.rst",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 21,
|
|
"author": {
|
|
"id": 105
|
|
},
|
|
"writtenOn": "2014-04-17T18:42:10Z",
|
|
"side": 1,
|
|
"message": "This picture doesn\u0027t line up nicely in the review. Did you try using asciiflow.com and pasting the result in here? That may work better.",
|
|
"revId": "31ffc682f64125f8639ae6d59632b4693779b590",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "AAAAXH//vyc\u003d",
|
|
"filename": "specs/juno/fsl-sdn-os-mech-driver.rst",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 32,
|
|
"author": {
|
|
"id": 261
|
|
},
|
|
"writtenOn": "2014-04-17T18:45:00Z",
|
|
"side": 1,
|
|
"message": "You can fix the diagram if you wish, but it seems it\u0027s simple enough that you can describe the situation with a text paragraph",
|
|
"revId": "31ffc682f64125f8639ae6d59632b4693779b590",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "AAAAXH//tmc\u003d",
|
|
"filename": "specs/juno/fsl-sdn-os-mech-driver.rst",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 32,
|
|
"author": {
|
|
"id": 8645
|
|
},
|
|
"writtenOn": "2014-04-18T01:33:57Z",
|
|
"side": 1,
|
|
"message": "okay",
|
|
"parentUuid": "AAAAXH//vyc\u003d",
|
|
"revId": "31ffc682f64125f8639ae6d59632b4693779b590",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "AAAAXH//wRk\u003d",
|
|
"filename": "specs/juno/fsl-sdn-os-mech-driver.rst",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 49,
|
|
"author": {
|
|
"id": 1689
|
|
},
|
|
"writtenOn": "2014-04-17T17:36:52Z",
|
|
"side": 1,
|
|
"message": "opetations-\u003eoperations",
|
|
"revId": "31ffc682f64125f8639ae6d59632b4693779b590",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "AAAAXH//tmA\u003d",
|
|
"filename": "specs/juno/fsl-sdn-os-mech-driver.rst",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 49,
|
|
"author": {
|
|
"id": 8645
|
|
},
|
|
"writtenOn": "2014-04-18T01:33:57Z",
|
|
"side": 1,
|
|
"message": "will handle in new draft patchset",
|
|
"parentUuid": "AAAAXH//wRk\u003d",
|
|
"revId": "31ffc682f64125f8639ae6d59632b4693779b590",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "AAAAXH//wRM\u003d",
|
|
"filename": "specs/juno/fsl-sdn-os-mech-driver.rst",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 50,
|
|
"author": {
|
|
"id": 1689
|
|
},
|
|
"writtenOn": "2014-04-17T17:36:52Z",
|
|
"side": 1,
|
|
"message": "Please indicate whether or not the new MD performs port binding. If so, describe how that works. If not, explain how this MD works in conjunction with other MDs.",
|
|
"revId": "31ffc682f64125f8639ae6d59632b4693779b590",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "AAAAXH//tk8\u003d",
|
|
"filename": "specs/juno/fsl-sdn-os-mech-driver.rst",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 50,
|
|
"author": {
|
|
"id": 8645
|
|
},
|
|
"writtenOn": "2014-04-18T01:33:57Z",
|
|
"side": 1,
|
|
"message": "MD does bind-port and ubind-port operations as the Openvswitch agent does. these definitions are called when ml2 is configured with mechanism drivers fslsdn and openvswitch.",
|
|
"parentUuid": "AAAAXH//wRM\u003d",
|
|
"revId": "31ffc682f64125f8639ae6d59632b4693779b590",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "AAAAXH//vxE\u003d",
|
|
"filename": "specs/juno/fsl-sdn-os-mech-driver.rst",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 61,
|
|
"author": {
|
|
"id": 261
|
|
},
|
|
"writtenOn": "2014-04-17T18:45:00Z",
|
|
"side": 1,
|
|
"message": "How will the CRD server store this information?\nThis is not important for Neutron, but I imagine it will create objects, and these objects might have identifiers.\nIf you are planning to store mappings between neutron and crd identifiers in neutron\u0027s data model you should state it here.",
|
|
"revId": "31ffc682f64125f8639ae6d59632b4693779b590",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "AAAAXH//tkk\u003d",
|
|
"filename": "specs/juno/fsl-sdn-os-mech-driver.rst",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 61,
|
|
"author": {
|
|
"id": 8645
|
|
},
|
|
"writtenOn": "2014-04-18T01:33:57Z",
|
|
"side": 1,
|
|
"message": "CRD service a new openstack neutron kind of service developed internally. is has its own database schema and keystone authentication credentials. No data releated to CRD is stored in Neutron data models. I will update the draft",
|
|
"parentUuid": "AAAAXH//vxE\u003d",
|
|
"revId": "31ffc682f64125f8639ae6d59632b4693779b590",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "AAAAXH//wQg\u003d",
|
|
"filename": "specs/juno/fsl-sdn-os-mech-driver.rst",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 81,
|
|
"author": {
|
|
"id": 2592
|
|
},
|
|
"writtenOn": "2014-04-17T17:36:09Z",
|
|
"side": 1,
|
|
"message": "Why is the neutron client necessary? Keystone client is already a dependency of Neutron. Does this not provide the correct authentication hooks you need?",
|
|
"revId": "31ffc682f64125f8639ae6d59632b4693779b590",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "AAAAXH//v1M\u003d",
|
|
"filename": "specs/juno/fsl-sdn-os-mech-driver.rst",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 81,
|
|
"author": {
|
|
"id": 261
|
|
},
|
|
"writtenOn": "2014-04-17T18:45:00Z",
|
|
"side": 1,
|
|
"message": "I can\u0027t help but I feel terribly confused by this statement:\n\"the crd server i a copy of the neutronclient httpclient class\".\n\nIs that a server or a client then?",
|
|
"revId": "31ffc682f64125f8639ae6d59632b4693779b590",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "AAAAXH//tjA\u003d",
|
|
"filename": "specs/juno/fsl-sdn-os-mech-driver.rst",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 81,
|
|
"author": {
|
|
"id": 8645
|
|
},
|
|
"writtenOn": "2014-04-18T01:33:57Z",
|
|
"side": 1,
|
|
"message": "misframed statement. CRD service is a neutron kind of service we developed for openstack internally.",
|
|
"parentUuid": "AAAAXH//v1M\u003d",
|
|
"revId": "31ffc682f64125f8639ae6d59632b4693779b590",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "AAAAXH//tjk\u003d",
|
|
"filename": "specs/juno/fsl-sdn-os-mech-driver.rst",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 81,
|
|
"author": {
|
|
"id": 8645
|
|
},
|
|
"writtenOn": "2014-04-18T01:33:57Z",
|
|
"side": 1,
|
|
"message": "Using latest neutron client, service-type, service and user-agent variables are hardcoded which we felt required to the configured. Since these variables are important for CRD service authentication, we went with a customized http client api from neutronclient http client api.",
|
|
"parentUuid": "AAAAXH//wQg\u003d",
|
|
"revId": "31ffc682f64125f8639ae6d59632b4693779b590",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "AAAAXH//v0Q\u003d",
|
|
"filename": "specs/juno/fsl-sdn-os-mech-driver.rst",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 87,
|
|
"author": {
|
|
"id": 261
|
|
},
|
|
"writtenOn": "2014-04-17T18:45:00Z",
|
|
"side": 1,
|
|
"message": "not really. You\u0027re adding a call to a 3rd party system for neutron API call. For instance, do you expect a create_port with the crd mech driver to be slower, or will the performance impact be negligible?",
|
|
"revId": "31ffc682f64125f8639ae6d59632b4693779b590",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "AAAAXH//tiI\u003d",
|
|
"filename": "specs/juno/fsl-sdn-os-mech-driver.rst",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 87,
|
|
"author": {
|
|
"id": 8645
|
|
},
|
|
"writtenOn": "2014-04-18T01:33:57Z",
|
|
"side": 1,
|
|
"message": "The impact is negligible.",
|
|
"parentUuid": "AAAAXH//v0Q\u003d",
|
|
"revId": "31ffc682f64125f8639ae6d59632b4693779b590",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "AAAAXH//vwU\u003d",
|
|
"filename": "specs/juno/fsl-sdn-os-mech-driver.rst",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 92,
|
|
"author": {
|
|
"id": 261
|
|
},
|
|
"writtenOn": "2014-04-17T18:45:00Z",
|
|
"side": 1,
|
|
"message": "Do you mean that this change won\u0027t have any effect with the default neutron configuration?",
|
|
"revId": "31ffc682f64125f8639ae6d59632b4693779b590",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "AAAAXH//thc\u003d",
|
|
"filename": "specs/juno/fsl-sdn-os-mech-driver.rst",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 92,
|
|
"author": {
|
|
"id": 8645
|
|
},
|
|
"writtenOn": "2014-04-18T01:33:57Z",
|
|
"side": 1,
|
|
"message": "I mean to say, by default this will not affect neutron configuration, If fslsdn mechanism driver is enabled in neutron, then driver specific configuration are required.",
|
|
"parentUuid": "AAAAXH//vwU\u003d",
|
|
"revId": "31ffc682f64125f8639ae6d59632b4693779b590",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "AAAAXH//vwA\u003d",
|
|
"filename": "specs/juno/fsl-sdn-os-mech-driver.rst",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 122,
|
|
"author": {
|
|
"id": 261
|
|
},
|
|
"writtenOn": "2014-04-17T18:45:00Z",
|
|
"side": 1,
|
|
"message": "I don\u0027t think there are dependencies for your blueprint!",
|
|
"revId": "31ffc682f64125f8639ae6d59632b4693779b590",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "AAAAXH//thY\u003d",
|
|
"filename": "specs/juno/fsl-sdn-os-mech-driver.rst",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 122,
|
|
"author": {
|
|
"id": 8645
|
|
},
|
|
"writtenOn": "2014-04-18T01:33:57Z",
|
|
"side": 1,
|
|
"message": "okay.. Since I\u0027m using certain apis from neutron they might be dependencies. Will update in the next patchset today.",
|
|
"parentUuid": "AAAAXH//vwA\u003d",
|
|
"revId": "31ffc682f64125f8639ae6d59632b4693779b590",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "AAAAXH//vvg\u003d",
|
|
"filename": "specs/juno/fsl-sdn-os-mech-driver.rst",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 127,
|
|
"author": {
|
|
"id": 261
|
|
},
|
|
"writtenOn": "2014-04-17T18:45:00Z",
|
|
"side": 1,
|
|
"message": "Do you mean existing testing or are you going to provide more tests (which, I think, you\u0027ll need to run on your own CI)",
|
|
"revId": "31ffc682f64125f8639ae6d59632b4693779b590",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "AAAAXH//tg0\u003d",
|
|
"filename": "specs/juno/fsl-sdn-os-mech-driver.rst",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 127,
|
|
"author": {
|
|
"id": 8645
|
|
},
|
|
"writtenOn": "2014-04-18T01:33:57Z",
|
|
"side": 1,
|
|
"message": "Existsing tempest tests which are al applicable for all ml2 mechanism drivers are also applicable for this mechanism driver",
|
|
"parentUuid": "AAAAXH//vvg\u003d",
|
|
"revId": "31ffc682f64125f8639ae6d59632b4693779b590",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
}
|
|
]
|
|
} |