openstack
/
neutron-specs
Code Issues Proposed changes
neutron-specs/5d72a935a960bf1106b863af6a3...

298 lines
8.7 KiB
Plaintext
Raw Blame History

{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "676bbc5f_21f8969d",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 6
},
"lineNbr": 0,
"author": {
"id": 1131
},
"writtenOn": "2023-03-20T18:33:12Z",
"side": 1,
"message": "Good work, very thorough, only had one nit.",
"revId": "5d72a935a960bf1106b863af6a392162a5b4b212",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "34d86f44_8e89b2c4",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 6
},
"lineNbr": 0,
"author": {
"id": 7730
},
"writtenOn": "2023-03-21T07:49:51Z",
"side": 1,
"message": "++",
"revId": "5d72a935a960bf1106b863af6a392162a5b4b212",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "e9e17348_f303bae2",
"filename": "specs/2023.2/active-active-l3-gateway-with-multihoming.rst",
"patchSetId": 6
},
"lineNbr": 100,
"author": {
"id": 7730
},
"writtenOn": "2023-03-21T07:49:51Z",
"side": 1,
"message": "I have difficulty to understand the phrasing but it\u0027s probably me :-)\n\nI guess this part will be the \"tricky one\" as we want to keep gw_port_id consistent regarding API and other agents",
"range": {
"startLine": 98,
"startChar": 0,
"endLine": 100,
"endChar": 59
},
"revId": "5d72a935a960bf1106b863af6a392162a5b4b212",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "8fb68625_936bf1df",
"filename": "specs/2023.2/active-active-l3-gateway-with-multihoming.rst",
"patchSetId": 6
},
"lineNbr": 100,
"author": {
"id": 13686
},
"writtenOn": "2023-03-22T10:14:41Z",
"side": 1,
"message": "Done",
"parentUuid": "e9e17348_f303bae2",
"range": {
"startLine": 98,
"startChar": 0,
"endLine": 100,
"endChar": 59
},
"revId": "5d72a935a960bf1106b863af6a392162a5b4b212",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "46d70965_a39607e2",
"filename": "specs/2023.2/active-active-l3-gateway-with-multihoming.rst",
"patchSetId": 6
},
"lineNbr": 104,
"author": {
"id": 7730
},
"writtenOn": "2023-03-21T07:49:51Z",
"side": 1,
"message": "Is there a necessity of ordering the ports returned?",
"range": {
"startLine": 102,
"startChar": 2,
"endLine": 104,
"endChar": 38
},
"revId": "5d72a935a960bf1106b863af6a392162a5b4b212",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "ffc43fcb_07623d9e",
"filename": "specs/2023.2/active-active-l3-gateway-with-multihoming.rst",
"patchSetId": 6
},
"lineNbr": 104,
"author": {
"id": 13686
},
"writtenOn": "2023-03-22T10:14:41Z",
"side": 1,
"message": "As laid out in the Router API section below, the API response for the ``external_gateways`` element [0] will indeed be ordered to list the compatibility gateway first [1].\n\n0: https://review.opendev.org/c/openstack/neutron-specs/+/870030/7/specs/2023.2/active-active-l3-gateway-with-multihoming.rst#192\n1: https://review.opendev.org/c/openstack/neutron/+/873593/23/neutron/db/l3_extra_gws_db.py#83",
"parentUuid": "46d70965_a39607e2",
"range": {
"startLine": 102,
"startChar": 2,
"endLine": 104,
"endChar": 38
},
"revId": "5d72a935a960bf1106b863af6a392162a5b4b212",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "ed8e7b5a_cb20db4a",
"filename": "specs/2023.2/active-active-l3-gateway-with-multihoming.rst",
"patchSetId": 6
},
"lineNbr": 104,
"author": {
"id": 7730
},
"writtenOn": "2023-03-29T08:52:34Z",
"side": 1,
"message": "Done",
"parentUuid": "ffc43fcb_07623d9e",
"range": {
"startLine": 102,
"startChar": 2,
"endLine": 104,
"endChar": 38
},
"revId": "5d72a935a960bf1106b863af6a392162a5b4b212",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "96c94991_63aa5749",
"filename": "specs/2023.2/active-active-l3-gateway-with-multihoming.rst",
"patchSetId": 6
},
"lineNbr": 143,
"author": {
"id": 1131
},
"writtenOn": "2023-03-20T18:33:12Z",
"side": 1,
"message": "Small typo: min_tx",
"range": {
"startLine": 143,
"startChar": 4,
"endLine": 143,
"endChar": 10
},
"revId": "5d72a935a960bf1106b863af6a392162a5b4b212",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "0e56208f_bdee4b5b",
"filename": "specs/2023.2/active-active-l3-gateway-with-multihoming.rst",
"patchSetId": 6
},
"lineNbr": 143,
"author": {
"id": 13686
},
"writtenOn": "2023-03-22T09:55:16Z",
"side": 1,
"message": "Done",
"parentUuid": "96c94991_63aa5749",
"range": {
"startLine": 143,
"startChar": 4,
"endLine": 143,
"endChar": 10
},
"revId": "5d72a935a960bf1106b863af6a392162a5b4b212",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "5e39ef16_d4f38a39",
"filename": "specs/2023.2/active-active-l3-gateway-with-multihoming.rst",
"patchSetId": 6
},
"lineNbr": 216,
"author": {
"id": 7730
},
"writtenOn": "2023-03-21T07:49:51Z",
"side": 1,
"message": "It\u0027s probably a noob question but why you can\u0027t?",
"range": {
"startLine": 214,
"startChar": 0,
"endLine": 216,
"endChar": 42
},
"revId": "5d72a935a960bf1106b863af6a392162a5b4b212",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "f1d8e68b_50510a6b",
"filename": "specs/2023.2/active-active-l3-gateway-with-multihoming.rst",
"patchSetId": 6
},
"lineNbr": 216,
"author": {
"id": 13686
},
"writtenOn": "2023-03-22T10:14:41Z",
"side": 1,
"message": "I think the reasoning is that we\u0027re adding this capability to the API while keeping compatibility with the existing API.\n\nWhat if someone were to PUT/POST a request that updates both the `external_gateway_info` and the `external_gateways`?",
"parentUuid": "5e39ef16_d4f38a39",
"range": {
"startLine": 214,
"startChar": 0,
"endLine": 216,
"endChar": 42
},
"revId": "5d72a935a960bf1106b863af6a392162a5b4b212",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "f53be410_4d818b82",
"filename": "specs/2023.2/active-active-l3-gateway-with-multihoming.rst",
"patchSetId": 6
},
"lineNbr": 216,
"author": {
"id": 11975
},
"writtenOn": "2023-03-23T16:27:59Z",
"side": 1,
"message": "I think it also could be race prone and if 2 clients would make requests updating this field it could be not updated properly. We have seen similar issue with extra routes field.",
"parentUuid": "f1d8e68b_50510a6b",
"range": {
"startLine": 214,
"startChar": 0,
"endLine": 216,
"endChar": 42
},
"revId": "5d72a935a960bf1106b863af6a392162a5b4b212",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "4906872f_975c0b8e",
"filename": "specs/2023.2/active-active-l3-gateway-with-multihoming.rst",
"patchSetId": 6
},
"lineNbr": 216,
"author": {
"id": 7730
},
"writtenOn": "2023-03-29T08:52:34Z",
"side": 1,
"message": "Done",
"parentUuid": "f53be410_4d818b82",
"range": {
"startLine": 214,
"startChar": 0,
"endLine": 216,
"endChar": 42
},
"revId": "5d72a935a960bf1106b863af6a392162a5b4b212",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}
View Git Blame Copy Permalink