openstack/neutron-tempest-plugin
Code Issues Proposed changes

Fix network sorting in API tests

Browse Source 
There is a mismatch in some tests because sorted() sorts in ASCII
order - digits are followed by uppercase characters and then
lowercase characters. That doesn't work if a network's name starts
with a capital letter.

Closes-Bug: #2049211
Change-Id: I8328d7d8ca7b49b99feb24d77525abdc064aae80
This commit is contained in:
Martin Kopec 2024-01-17 12:02:24 +01:00
parent 7d950d78a2
commit 71a7324508
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
neutron_tempest_plugin/api/base.py
View File

@ -1437,7 +1437,9 @@ class BaseSearchCriteriaTest(BaseNetworkTest):
self.assertNotEmpty(
resources, "%s list returned is empty" % self.resource)
retrieved_names = [res[self.field] for res in resources]
expected = sorted(retrieved_names)
# sort without taking into account whether the network is named with
# a capital letter or not
expected = sorted(retrieved_names, key=lambda v: v.upper())
if direction == constants.SORT_DIRECTION_DESC:
expected = list(reversed(expected))
self.assertEqual(expected, retrieved_names)