From 9be9375131ad08c016d0f2de2c8ddc5e4b3eab23 Mon Sep 17 00:00:00 2001 From: Roman Safronov Date: Tue, 17 Sep 2024 14:57:48 +0300 Subject: [PATCH] Skip NetworkWritableMtuTest when driver is ML2/OVN East/west icmp fragmentation is not supported with ML2/OVN since there is no production use case, as mentioned in [1]. With this change NetworkWritableMtuTest will be skipped automatically when ML2/OVN agents found and thus ci jobs configs can be simplified by removing exclude list. [1] https://docs.openstack.org/neutron/latest/ovn/gaps.html Change-Id: I7f690b1a260ff70e12bcfac82f63e36ddca7cfbc --- neutron_tempest_plugin/scenario/test_mtu.py | 12 +++--------- zuul.d/2023_1_jobs.yaml | 4 ---- zuul.d/2023_2_jobs.yaml | 4 ---- zuul.d/2024_1_jobs.yaml | 4 ---- zuul.d/master_jobs.yaml | 4 ---- zuul.d/zed_jobs.yaml | 2 -- 6 files changed, 3 insertions(+), 27 deletions(-) diff --git a/neutron_tempest_plugin/scenario/test_mtu.py b/neutron_tempest_plugin/scenario/test_mtu.py index ea62fcf5..99c5130f 100644 --- a/neutron_tempest_plugin/scenario/test_mtu.py +++ b/neutron_tempest_plugin/scenario/test_mtu.py @@ -169,19 +169,13 @@ class NetworkWritableMtuTest(NetworkMtuBaseTest): servers = [] networks = [] - @classmethod - def skip_checks(cls): - super(NetworkWritableMtuTest, cls).skip_checks() - supported_type_drivers = ['vxlan', 'geneve'] - if not any(type_driver in supported_type_drivers for type_driver in - config.CONF.neutron_plugin_options.available_type_drivers): - raise cls.skipException( - "Neither VXLAN nor GENEVE type_driver is enabled") - @classmethod @utils.requires_ext(extension="net-mtu-writable", service="network") def resource_setup(cls): super(NetworkWritableMtuTest, cls).resource_setup() + if cls.is_driver_ovn: + raise cls.skipException("East/west icmp fragmentation is not " + "supported with ML2/OVN") def _create_setup(self): self.admin_client = self.os_admin.network_client diff --git a/zuul.d/2023_1_jobs.yaml b/zuul.d/2023_1_jobs.yaml index 4325b837..32e2c4cb 100644 --- a/zuul.d/2023_1_jobs.yaml +++ b/zuul.d/2023_1_jobs.yaml @@ -210,10 +210,6 @@ (^neutron_tempest_plugin.scenario)|\ (^tempest.api.compute.servers.test_attach_interfaces)|\ (^tempest.api.compute.servers.test_multiple_create)" - # TODO(jlibosva): Remove the NetworkWritableMtuTest test from the list - # once east/west fragmentation is supported in core OVN - tempest_exclude_regex: "\ - (^neutron_tempest_plugin.scenario.test_mtu.NetworkWritableMtuTest)" devstack_localrc: NETWORK_API_EXTENSIONS: "{{ (network_api_extensions_common + network_api_extensions_ovn) | join(',') }}" devstack_services: diff --git a/zuul.d/2023_2_jobs.yaml b/zuul.d/2023_2_jobs.yaml index 74064404..7aa16421 100644 --- a/zuul.d/2023_2_jobs.yaml +++ b/zuul.d/2023_2_jobs.yaml @@ -205,10 +205,6 @@ (^neutron_tempest_plugin.scenario)|\ (^tempest.api.compute.servers.test_attach_interfaces)|\ (^tempest.api.compute.servers.test_multiple_create)" - # TODO(jlibosva): Remove the NetworkWritableMtuTest test from the list - # once east/west fragmentation is supported in core OVN - tempest_exclude_regex: "\ - (^neutron_tempest_plugin.scenario.test_mtu.NetworkWritableMtuTest)" devstack_localrc: NETWORK_API_EXTENSIONS: "{{ (network_api_extensions_common + network_api_extensions_ovn) | join(',') }}" devstack_services: diff --git a/zuul.d/2024_1_jobs.yaml b/zuul.d/2024_1_jobs.yaml index f0a182ba..86fbc52f 100644 --- a/zuul.d/2024_1_jobs.yaml +++ b/zuul.d/2024_1_jobs.yaml @@ -207,10 +207,6 @@ (^neutron_tempest_plugin.scenario)|\ (^tempest.api.compute.servers.test_attach_interfaces)|\ (^tempest.api.compute.servers.test_multiple_create)" - # TODO(jlibosva): Remove the NetworkWritableMtuTest test from the list - # once east/west fragmentation is supported in core OVN - tempest_exclude_regex: "\ - (^neutron_tempest_plugin.scenario.test_mtu.NetworkWritableMtuTest)" devstack_localrc: NETWORK_API_EXTENSIONS: "{{ (network_api_extensions_common + network_api_extensions_ovn) | join(',') }}" devstack_local_conf: diff --git a/zuul.d/master_jobs.yaml b/zuul.d/master_jobs.yaml index b2e6c86c..55187988 100644 --- a/zuul.d/master_jobs.yaml +++ b/zuul.d/master_jobs.yaml @@ -627,10 +627,6 @@ network_api_extensions_ovn: - vlan-transparent - external-gateway-multihoming - # TODO(jlibosva): Remove the NetworkWritableMtuTest test from the list - # once east/west fragmentation is supported in core OVN - tempest_exclude_regex: "\ - (^neutron_tempest_plugin.scenario.test_mtu.NetworkWritableMtuTest)" devstack_localrc: Q_AGENT: ovn OVN_AGENT_EXTENSIONS: 'metadata' diff --git a/zuul.d/zed_jobs.yaml b/zuul.d/zed_jobs.yaml index 176527de..54e9af5f 100644 --- a/zuul.d/zed_jobs.yaml +++ b/zuul.d/zed_jobs.yaml @@ -186,8 +186,6 @@ (^neutron_tempest_plugin.scenario)|\ (^tempest.api.compute.servers.test_attach_interfaces)|\ (^tempest.api.compute.servers.test_multiple_create)" - tempest_exclude_regex: "\ - (^neutron_tempest_plugin.scenario.test_mtu.NetworkWritableMtuTest)" network_api_extensions: *api_extensions network_api_extensions_ovn: - vlan-transparent