From 45ae5c00e357877936766601758c6c4d05f4801f Mon Sep 17 00:00:00 2001 From: Ihar Hrachyshka Date: Fri, 8 Aug 2014 00:04:44 +0200 Subject: [PATCH] Use jsonutils instead of stdlib json jsonutils provides multiple benefits in comparison to pure stdlib json (like using simplejson on Python 2.6). Similar patch was already merged before [1], but since it lacked hacking rule to enforce jsonutils usage, new occurrences of stdlib json module usage were introduced. This patch switches all the code to using jsonutils and adds a hacking rule to enforce the rule. The hacking rule requires that jsonutils module does not mimic as 'json' thru using import renames, so the code was updated not to rename the module when doing import. The hacking rule was shamelessly copied from the corresponding nova review [2]. [1]: https://review.openstack.org/#/c/99760/ [2]: https://review.openstack.org/111296/ Change-Id: Ie7a5bb76445e15cde9fbf9ff3d2101a014637b37 --- HACKING.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/HACKING.rst b/HACKING.rst index 84f6f3e1c..0f3666fc0 100644 --- a/HACKING.rst +++ b/HACKING.rst @@ -9,6 +9,7 @@ Neutron Specific Commandments -------------------------- - [N320] Validate that LOG messages, except debug ones, have translations +- [N321] Validate that jsonutils module is used instead of json Creating Unit Tests -------------------