openstack/neutron-vpnaas
Code Issues Proposed changes

Enable some off-by-default checks

Browse Source 
Some of the available checks are disabled by default, like:
[H106] Don't put vim configuration in source files
[H203] Use assertIs(Not)None to check for None
[H904] Delay string interpolations at logging calls

Change-Id: I7450cd259fffa2a97fcb28cc61727532478eeccb
This commit is contained in:
Cao Xuan Hoang 2017-07-06 09:38:29 +07:00
parent 4b923bca84
commit 4dc446542d
4 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
neutron_vpnaas/services/vpn/device_drivers/ipsec.py
View File

@ -465,7 +465,7 @@ class OpenSwanProcess(BaseSwanProcess):
# indicates something bad has happened and this is # indicates something bad has happened and this is
# valuable information for figuring it out. # valuable information for figuring it out.
LOG.error('Process %(pid)s exists with command ' LOG.error('Process %(pid)s exists with command '
'line %(cmd_line)s.' % 'line %(cmd_line)s.',
{'pid': pid, 'cmd_line': cmd_line}) {'pid': pid, 'cmd_line': cmd_line})
return True return True

2
neutron_vpnaas/services/vpn/device_drivers/strongswan_ipsec.py
View File

@ -82,7 +82,7 @@ class StrongSwanProcess(ipsec.BaseSwanProcess):
self.DIALECT_MAP['v2'] = 'ikev2' self.DIALECT_MAP['v2'] = 'ikev2'
self.DIALECT_MAP['sha256'] = 'sha256' self.DIALECT_MAP['sha256'] = 'sha256'
self._strongswan_piddir = self._get_strongswan_piddir() self._strongswan_piddir = self._get_strongswan_piddir()
LOG.debug("strongswan piddir is '%s'" % (self._strongswan_piddir)) LOG.debug("strongswan piddir is '%s'", (self._strongswan_piddir))
super(StrongSwanProcess, self).__init__(conf, process_id, super(StrongSwanProcess, self).__init__(conf, process_id,
vpnservice, namespace) vpnservice, namespace)

2
neutron_vpnaas/services/vpn/plugin.py
View File

@ -137,7 +137,7 @@ class VPNDriverPlugin(VPNPlugin, vpn_db.VPNPluginRpcDbMixin):
# Use default provider # Use default provider
provider = self.default_provider provider = self.default_provider
LOG.debug("Selected provider %s" % provider) LOG.debug("Selected provider %s", provider)
return provider return provider
def _get_driver_for_vpnservice(self, context, vpnservice): def _get_driver_for_vpnservice(self, context, vpnservice):

5
tox.ini
View File

@ -87,7 +87,12 @@ commands = sphinx-build -W -b html doc/source doc/build
# H405 multi line docstring summary not separated with an empty line # H405 multi line docstring summary not separated with an empty line
# TODO(dougwig) -- uncomment this to test for remaining linkages # TODO(dougwig) -- uncomment this to test for remaining linkages
# N530 direct neutron imports not allowed # N530 direct neutron imports not allowed
# N531 Log messages require translation hints
# H106 Don't put vim configuration in source files
# H203 Use assertIs(Not)None to check for None
# H904 Delay string interpolations at logging calls
ignore = E125,E126,E128,E129,E265,H404,H405,N530,N531 ignore = E125,E126,E128,E129,E265,H404,H405,N530,N531
enable-extensions=H106,H203,H904
show-source = true show-source = true
exclude = .venv,.git,.tox,dist,doc,.tmp,*lib/python*,*egg,build,tools,.ropeproject,rally-scenarios exclude = .venv,.git,.tox,dist,doc,.tmp,*lib/python*,*egg,build,tools,.ropeproject,rally-scenarios
import-order-style = pep8 import-order-style = pep8