Update patch set 1
Patch Set 1: Code-Review+1 (3 comments) Patch-set: 1 Reviewer: Gerrit User 8556 <8556@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=+1, 3afce41409025fb346546909fc2c9338e963f3b0 Attention: {"person_ident":"Gerrit User 8313 \u003c8313@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_8556\u003e replied on the change"}
This commit is contained in:
parent
628b6db2eb
commit
5a3c7073fb
67
a527762a07499a0198dc41777399517f35c51367
Normal file
67
a527762a07499a0198dc41777399517f35c51367
Normal file
@ -0,0 +1,67 @@
|
|||||||
|
{
|
||||||
|
"comments": [
|
||||||
|
{
|
||||||
|
"unresolved": true,
|
||||||
|
"key": {
|
||||||
|
"uuid": "6e014731_89097bda",
|
||||||
|
"filename": ".zuul.yaml",
|
||||||
|
"patchSetId": 1
|
||||||
|
},
|
||||||
|
"lineNbr": 22,
|
||||||
|
"author": {
|
||||||
|
"id": 8556
|
||||||
|
},
|
||||||
|
"writtenOn": "2024-03-26T18:09:10Z",
|
||||||
|
"side": 1,
|
||||||
|
"message": "if am not wrong, all these are same as what we have in openstack-python3-jobs-neutron, can we remove these from here and they will be applied from genric template automatically? \n\n- https://github.com/openstack/openstack-zuul-jobs/blob/3dbb70af7cc0b9d09d4a9b67a70a0cceafea77ce/zuul.d/project-templates.yaml#L886",
|
||||||
|
"range": {
|
||||||
|
"startLine": 11,
|
||||||
|
"startChar": 0,
|
||||||
|
"endLine": 22,
|
||||||
|
"endChar": 39
|
||||||
|
},
|
||||||
|
"revId": "a527762a07499a0198dc41777399517f35c51367",
|
||||||
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"unresolved": true,
|
||||||
|
"key": {
|
||||||
|
"uuid": "aa4c4722_51ebf51f",
|
||||||
|
"filename": ".zuul.yaml",
|
||||||
|
"patchSetId": 1
|
||||||
|
},
|
||||||
|
"lineNbr": 42,
|
||||||
|
"author": {
|
||||||
|
"id": 8556
|
||||||
|
},
|
||||||
|
"writtenOn": "2024-03-26T18:09:10Z",
|
||||||
|
"side": 1,
|
||||||
|
"message": "ditto",
|
||||||
|
"range": {
|
||||||
|
"startLine": 31,
|
||||||
|
"startChar": 0,
|
||||||
|
"endLine": 42,
|
||||||
|
"endChar": 33
|
||||||
|
},
|
||||||
|
"revId": "a527762a07499a0198dc41777399517f35c51367",
|
||||||
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"unresolved": false,
|
||||||
|
"key": {
|
||||||
|
"uuid": "0e326726_c0e248f5",
|
||||||
|
"filename": "/PATCHSET_LEVEL",
|
||||||
|
"patchSetId": 1
|
||||||
|
},
|
||||||
|
"lineNbr": 0,
|
||||||
|
"author": {
|
||||||
|
"id": 8556
|
||||||
|
},
|
||||||
|
"writtenOn": "2024-03-26T18:09:10Z",
|
||||||
|
"side": 1,
|
||||||
|
"message": "lgtm, one suggestion to make it easy.",
|
||||||
|
"revId": "a527762a07499a0198dc41777399517f35c51367",
|
||||||
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||||
|
}
|
||||||
|
]
|
||||||
|
}
|
Loading…
Reference in New Issue
Block a user