From 7f4927e811c9e649db2a2c0116c57e6625fe1542 Mon Sep 17 00:00:00 2001 From: Gerrit User 31976 <31976@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Fri, 19 Jan 2024 16:12:17 +0000 Subject: [PATCH] Update patch set 2 Patch Set 2: (1 comment) Patch-set: 2 CC: Gerrit User 31976 <31976@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Attention: {"person_ident":"Gerrit User 28619 \u003c28619@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_31976\u003e replied on the change"} --- 256464aea691f8b4957ba668a117963353f34e4c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 256464aea691f8b4957ba668a117963353f34e4c diff --git a/256464aea691f8b4957ba668a117963353f34e4c b/256464aea691f8b4957ba668a117963353f34e4c new file mode 100644 index 000000000..76d4a5cb9 --- /dev/null +++ b/256464aea691f8b4957ba668a117963353f34e4c @@ -0,0 +1,21 @@ +{ + "comments": [ + { + "unresolved": true, + "key": { + "uuid": "edda46a8_8ab91d3e", + "filename": "neutron_vpnaas/db/vpn/vpn_models.py", + "patchSetId": 2 + }, + "lineNbr": 108, + "author": { + "id": 31976 + }, + "writtenOn": "2024-01-19T16:12:17Z", + "side": 0, + "message": "I don\u0027t think removing it here is enough. Maybe there should be a DB migration too. And it should be removed from the API definition in neutron-lib (neutron_lib/api/definitions/vpn.py VPN_SUPPORTED_DPD_ACTIONS).", + "revId": "256464aea691f8b4957ba668a117963353f34e4c", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + } + ] +} \ No newline at end of file