openstack
/
neutron-vpnaas
Code Issues Proposed changes

Update patch set 34 

Patch Set 34: Code-Review+2

(1 comment)

Patch-set: 34
Reviewer: Gerrit User 11975 <11975@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+2, b484adcb90742d5b966f67fae247c0e3bfbb40ee
Attention: {"person_ident":"Gerrit User 11975 \u003c11975@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_11975\u003e replied on the change"}
This commit is contained in:
Gerrit User 11975 2023-11-08 10:50:50 +00:00 committed by Gerrit Code Review
parent 0b3c0aba51
commit bb5b8aa702
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
8815e6e3917e45fdfdc6077aed740da2e1c8d1f5
View File

@ -16,6 +16,23 @@
"message": "This looks quite fair to me and it\u0027s confirmed to work by multiple operators. This also passes tempest test, so might worth having a shot and do a follow-up work whenever needed.",
"revId": "8815e6e3917e45fdfdc6077aed740da2e1c8d1f5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "23d52b7c_f5b44fe3",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 34
},
"lineNbr": 0,
"author": {
"id": 11975
},
"writtenOn": "2023-11-08T10:50:50Z",
"side": 1,
"message": "I\u0027m not VPNaaS expert but looking just at the python code it looks good for me. It also passed the gate and was already reviewed (and tested in production even AFAIK) by some operators so LGTM for me.",
"revId": "8815e6e3917e45fdfdc6077aed740da2e1c8d1f5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}