openstack
/
neutron-vpnaas
Code Issues Proposed changes

Update patch set 31 

Patch Set 31:

(8 comments)

Patch-set: 31
This commit is contained in:
Gerrit User 31976 2023-07-25 09:43:59 +00:00 committed by Gerrit Code Review
parent 6fe42ef769
commit d64656f618
3 changed files with 150 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
462a7b8ccfe455029b36e0ae3bc0f66bfcc0c1f5
View File

@ -122,6 +122,24 @@
"revId": "462a7b8ccfe455029b36e0ae3bc0f66bfcc0c1f5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "db9726e1_4e1ddad5",
"filename": "neutron_vpnaas/db/migration/alembic_migrations/versions/yoga/expand/3b739d6906cf_vpn_scheduler.py",
"patchSetId": 17
},
"lineNbr": 37,
"author": {
"id": 31976
},
"writtenOn": "2023-07-25T09:43:59Z",
"side": 1,
"message": "the columns are always filled, so I changed it to nullable\u003dFalse",
"parentUuid": "4abc855a_716ee143",
"revId": "462a7b8ccfe455029b36e0ae3bc0f66bfcc0c1f5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {

108
b784c22021750c816e9db7473a63784d25f07502
View File

@ -34,6 +34,24 @@
"revId": "b784c22021750c816e9db7473a63784d25f07502",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "018fc1e3_d4b32742",
"filename": "neutron_vpnaas/services/vpn/service_drivers/ovn_ipsec.py",
"patchSetId": 29
},
"lineNbr": 56,
"author": {
"id": 31976
},
"writtenOn": "2023-07-25T09:43:59Z",
"side": 1,
"message": "changed it",
"parentUuid": "9296183f_6079b4ab",
"revId": "b784c22021750c816e9db7473a63784d25f07502",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -51,6 +69,24 @@
"revId": "b784c22021750c816e9db7473a63784d25f07502",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "7c55807e_1f9c9617",
"filename": "neutron_vpnaas/tests/functional/openswan/test_ovn_openswan.py",
"patchSetId": 29
},
"lineNbr": 1,
"author": {
"id": 31976
},
"writtenOn": "2023-07-25T09:43:59Z",
"side": 1,
"message": "added it",
"parentUuid": "27368e6b_2851517a",
"revId": "b784c22021750c816e9db7473a63784d25f07502",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -68,6 +104,24 @@
"revId": "b784c22021750c816e9db7473a63784d25f07502",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "109df4fc_91f1c876",
"filename": "neutron_vpnaas/tests/functional/strongswan/test_ovn_strongswan.py",
"patchSetId": 29
},
"lineNbr": 1,
"author": {
"id": 31976
},
"writtenOn": "2023-07-25T09:43:59Z",
"side": 1,
"message": "added the license",
"parentUuid": "24b59494_83c5cd06",
"revId": "b784c22021750c816e9db7473a63784d25f07502",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -85,6 +139,24 @@
"revId": "b784c22021750c816e9db7473a63784d25f07502",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "c24b6273_c30cfe75",
"filename": "neutron_vpnaas/tests/unit/db/vpn/test_vpn_ext_gw_db.py",
"patchSetId": 29
},
"lineNbr": 11,
"author": {
"id": 31976
},
"writtenOn": "2023-07-25T09:43:59Z",
"side": 1,
"message": "fixed",
"parentUuid": "963e2488_a8b151e7",
"revId": "b784c22021750c816e9db7473a63784d25f07502",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -102,6 +174,24 @@
"revId": "b784c22021750c816e9db7473a63784d25f07502",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "75049a85_64e33eb7",
"filename": "neutron_vpnaas/tests/unit/services/vpn/device_drivers/test_ovn_ipsec.py",
"patchSetId": 29
},
"lineNbr": 15,
"author": {
"id": 31976
},
"writtenOn": "2023-07-25T09:43:59Z",
"side": 1,
"message": "fixed",
"parentUuid": "34535881_fb122c02",
"revId": "b784c22021750c816e9db7473a63784d25f07502",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -119,6 +209,24 @@
"revId": "b784c22021750c816e9db7473a63784d25f07502",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "a91465bf_3da88406",
"filename": "releasenotes/notes/vpnaas-for-ovn-a487c62b877e3201.yaml",
"patchSetId": 29
},
"lineNbr": 3,
"author": {
"id": 31976
},
"writtenOn": "2023-07-25T09:43:59Z",
"side": 1,
"message": "changed it",
"parentUuid": "7412eb5c_847e0ae4",
"revId": "b784c22021750c816e9db7473a63784d25f07502",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {

24
e3295152da13ea3786b15ead609f5a58fe288eb4
View File

@ -198,6 +198,30 @@
},
"revId": "e3295152da13ea3786b15ead609f5a58fe288eb4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "02ec24bd_ad59ab41",
"filename": "neutron_vpnaas/db/migration/alembic_migrations/versions/yoga/expand/22e0145ac80b_add_vpn_gateway_port.py",
"patchSetId": 26
},
"lineNbr": 1,
"author": {
"id": 31976
},
"writtenOn": "2023-07-25T09:43:59Z",
"side": 1,
"message": "the 2016 line is there because the code is based on work of MingShuang Xian back in 2016. I changed our line to 2023.",
"parentUuid": "c92cc8e7_63707c80",
"range": {
"startLine": 1,
"startChar": 0,
"endLine": 1,
"endChar": 36
},
"revId": "e3295152da13ea3786b15ead609f5a58fe288eb4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}