810a3fea8b
Patch Set 5:
(1 comment)
Patch-set: 5
Reviewer: Gerrit User 8313 <8313@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Reviewer: Gerrit User 11221 <11221@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Attention: {"person_ident":"Gerrit User 1004 \u003c1004@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_32755\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 31976 \u003c31976@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_32755\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 8313 \u003c8313@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_32755\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 11221 \u003c11221@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_32755\u003e replied on the change"}
21 lines
902 B
Plaintext
21 lines
902 B
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "d11351c2_6be4b05d",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 5
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 32755
|
|
},
|
|
"writtenOn": "2024-02-12T16:58:50Z",
|
|
"side": 1,
|
|
"message": "Sorry guys for the delay. We now revisited this patch again and rebased it to the current master while (hopefully) fixing all of the tests. Especially them tests were a little challenging, as \"Router\" and \"RouterInfo\" objects are seemingly used with little relation to their variables names. The lack of type annotations also contributed.\n\nIn any case, we tried to give this a good shot again and would appreciate your kind review time and input.",
|
|
"revId": "b89ecaee2b7f3634cf54dee4d67df99a4a1b2593",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |