1. In reviews we usually check import grouping but it is boring. By using flake8-import-order plugin, we can avoid this. It enforces loose checking so it sounds good to use it. This flake8 plugin is already used in tempest. Note that flake8-import-order version is pinned to avoid unexpected breakage of pep8 job. Setup for unit tests of hacking rules is tweaked to disable flake8-import-order checks. This extension assumes an actual file exists and causes hacking rule unit tests. 2. This patch is also intend to clean up exceptions to avoid confusing for other developers and the maintenance-ability as well. Change-Id: I032892f08e073feb5b822d27d092f041b17d57e1
89 lines
2.5 KiB
Python
89 lines
2.5 KiB
Python
# Copyright 2014 OpenStack Foundation
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
from logging import config as logging_config
|
|
|
|
from alembic import context
|
|
from neutron_lib.db import model_base
|
|
from oslo_config import cfg
|
|
from oslo_db.sqlalchemy import session
|
|
import sqlalchemy as sa
|
|
from sqlalchemy import event
|
|
|
|
|
|
from neutron_vpnaas.db.migration import alembic_migrations
|
|
|
|
|
|
MYSQL_ENGINE = None
|
|
config = context.config
|
|
neutron_config = config.neutron_config
|
|
logging_config.fileConfig(config.config_file_name)
|
|
target_metadata = model_base.BASEV2.metadata
|
|
|
|
|
|
def set_mysql_engine():
|
|
try:
|
|
mysql_engine = neutron_config.command.mysql_engine
|
|
except cfg.NoSuchOptError:
|
|
mysql_engine = None
|
|
|
|
global MYSQL_ENGINE
|
|
MYSQL_ENGINE = (mysql_engine or
|
|
model_base.BASEV2.__table_args__['mysql_engine'])
|
|
|
|
|
|
def run_migrations_offline():
|
|
set_mysql_engine()
|
|
|
|
kwargs = dict()
|
|
if neutron_config.database.connection:
|
|
kwargs['url'] = neutron_config.database.connection
|
|
else:
|
|
kwargs['dialect_name'] = neutron_config.database.engine
|
|
kwargs['version_table'] = alembic_migrations.VPNAAS_VERSION_TABLE
|
|
context.configure(**kwargs)
|
|
|
|
with context.begin_transaction():
|
|
context.run_migrations()
|
|
|
|
|
|
@event.listens_for(sa.Table, 'after_parent_attach')
|
|
def set_storage_engine(target, parent):
|
|
if MYSQL_ENGINE:
|
|
target.kwargs['mysql_engine'] = MYSQL_ENGINE
|
|
|
|
|
|
def run_migrations_online():
|
|
set_mysql_engine()
|
|
engine = session.create_engine(neutron_config.database.connection)
|
|
|
|
connection = engine.connect()
|
|
context.configure(
|
|
connection=connection,
|
|
target_metadata=target_metadata,
|
|
version_table=alembic_migrations.VPNAAS_VERSION_TABLE
|
|
)
|
|
try:
|
|
with context.begin_transaction():
|
|
context.run_migrations()
|
|
finally:
|
|
connection.close()
|
|
engine.dispose()
|
|
|
|
|
|
if context.is_offline_mode():
|
|
run_migrations_offline()
|
|
else:
|
|
run_migrations_online()
|