Update patch set 1
Patch Set 1: (1 comment) Just one comment, patch is legit Patch-set: 1 CC: Gerrit User 16688 <16688@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
This commit is contained in:
parent
d2f2fd51e9
commit
00a11f231c
|
@ -0,0 +1,27 @@
|
||||||
|
{
|
||||||
|
"comments": [
|
||||||
|
{
|
||||||
|
"key": {
|
||||||
|
"uuid": "2bdf59bc_19554d00",
|
||||||
|
"filename": "neutron/agent/ovn/metadata/server.py",
|
||||||
|
"patchSetId": 1
|
||||||
|
},
|
||||||
|
"lineNbr": 56,
|
||||||
|
"author": {
|
||||||
|
"id": 16688
|
||||||
|
},
|
||||||
|
"writtenOn": "2021-06-16T15:08:17Z",
|
||||||
|
"side": 1,
|
||||||
|
"message": "Instead of checking \"self._post_fork_event\" always, it could be faster to check only for the \"self._sb_idl\" value\n\n def __init__(self, conf, chassis):\n self._sb_idl \u003d None\n\n @property\n def sb_idl(self):\n if not self._sb_idl\n self._post_fork_event.wait()\n \n return self._sb_idl",
|
||||||
|
"range": {
|
||||||
|
"startLine": 55,
|
||||||
|
"startChar": 8,
|
||||||
|
"endLine": 56,
|
||||||
|
"endChar": 27
|
||||||
|
},
|
||||||
|
"revId": "b608415b36b59e724e93f1a1dcc68a6c6cf7a253",
|
||||||
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||||
|
"unresolved": true
|
||||||
|
}
|
||||||
|
]
|
||||||
|
}
|
Loading…
Reference in New Issue