openstack/neutron
Code Issues Proposed changes

Cleanup before executing "test_get_all_devices"

Browse Source 
The test "test_get_all_devices" is executed wiht concurrency=1. Before
executing the test checks, this patch removes any existing macvtap
interface present in the root namespace.

Closes-Bug: #2012510
Change-Id: I98834fc6719caa4909c737f5fe37a8dc51035d6d
This commit is contained in:
Rodolfo Alonso Hernandez 2023-03-21 22:32:54 +01:00
parent 11ace380fe
commit 0220236c63
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
neutron/tests/functional/plugins/ml2/drivers/macvtap/agent/test_macvtap_neutron_agent.py
View File

@ -16,6 +16,7 @@
from neutron_lib import constants from neutron_lib import constants
from neutron.agent.linux import ip_lib
from neutron.plugins.ml2.drivers.macvtap.agent import macvtap_neutron_agent from neutron.plugins.ml2.drivers.macvtap.agent import macvtap_neutron_agent
from neutron.tests.common import net_helpers from neutron.tests.common import net_helpers
from neutron.tests.functional import base as functional_base from neutron.tests.functional import base as functional_base
@ -27,6 +28,16 @@ class MacvtapAgentTestCase(functional_base.BaseSudoTestCase):
self.mgr = macvtap_neutron_agent.MacvtapManager({}) self.mgr = macvtap_neutron_agent.MacvtapManager({})
def test_get_all_devices(self): def test_get_all_devices(self):
# NOTE(ralonsoh): Clean-up before testing. This test is executed with
# concurrency=1. That means no other test is being executed at the same
# time. Because the macvtap interface must be created in the root
# namespace (``MacvtapManager`` cannot handle namespaces), the test
# deletes any previous existing interface.
for mac in self.mgr.get_all_devices():
devices = ip_lib.IPWrapper().get_devices()
for device in (d for d in devices if d.address == mac):
device.link.delete()
# Veth is simulating the hosts eth device. In this test it is used as # Veth is simulating the hosts eth device. In this test it is used as
# src_dev for the macvtap # src_dev for the macvtap
veth1, veth2 = self.useFixture(net_helpers.VethFixture()).ports veth1, veth2 = self.useFixture(net_helpers.VethFixture()).ports