From 033ab6cc1790138fcab874f6c1aa3144893cc5cb Mon Sep 17 00:00:00 2001 From: Bernard Cafarelli Date: Tue, 20 Jun 2017 17:12:36 +0200 Subject: [PATCH] python3: use binary mode to open file in test With text mode, trying to write a binary string generates a TypeError in python 3 Change-Id: I1b7d1a46d98814aacb4bf9a7f80b168c2b786e30 --- neutron/tests/functional/test_server.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/neutron/tests/functional/test_server.py b/neutron/tests/functional/test_server.py index b0a28c05efe..6f6252227ce 100644 --- a/neutron/tests/functional/test_server.py +++ b/neutron/tests/functional/test_server.py @@ -130,7 +130,7 @@ class TestNeutronServer(base.BaseTestCase): return True def _fake_start(self): - with open(self.temp_file, 'a') as f: + with open(self.temp_file, 'ab') as f: f.write(FAKE_START_MSG) def _test_restart_service_on_sighup(self, service, workers=1): @@ -164,7 +164,7 @@ class TestNeutronServer(base.BaseTestCase): # Verify that start has been called twice for each worker (one for # initial start, and the second one on SIGHUP after children were # terminated). - with open(self.temp_file, 'r') as f: + with open(self.temp_file, 'rb') as f: res = f.readline() self.assertEqual(expected_msg, res)