openstack/neutron
Code Issues Proposed changes

remove pep8 E122 exemption and correct style

Browse Source 
This change removes the E122 exemption for pep8. E122 is "continuation line missing indentation or outdented"

Change-Id: I4bd1e6c787648a3dfa69b514efeeff05996aabc1
Partial-Bug: 1329017
This commit is contained in:
Mark McClain 2014-06-11 19:47:12 -04:00
parent e3725e818a
commit 14fb3ec932
3 changed files with 8 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
neutron/plugins/vmware/nsxlib/secgroup.py
View File

@ -123,13 +123,11 @@ def update_security_group_rules(cluster, spid, rules):
def update_security_profile(cluster, spid, name):
return nsxlib.do_request(HTTP_PUT,
nsxlib._build_uri_path(SECPROF_RESOURCE,
resource_id=spid),
json.dumps({
"display_name": utils.check_and_truncate(name)
}),
cluster=cluster)
return nsxlib.do_request(
HTTP_PUT,
nsxlib._build_uri_path(SECPROF_RESOURCE, resource_id=spid),
json.dumps({"display_name": utils.check_and_truncate(name)}),
cluster=cluster)
def delete_security_profile(cluster, spid):

4
neutron/tests/unit/services/vpn/device_drivers/test_cisco_ipsec.py
View File

@ -1502,8 +1502,8 @@ class TestCiscoCsrIPsecDeviceDriverSyncStatuses(base.BaseTestCase):
u'ipsec_site_connections': {
u'1': {u'status': constants.ACTIVE,
u'updated_pending_status': True},
u'2': {u'status': constants.DOWN,
u'updated_pending_status': True}}
u'2': {u'status': constants.DOWN,
u'updated_pending_status': True}}
},
{u'id': u'456',
u'updated_pending_status': True,

3
tox.ini
View File

@ -40,7 +40,6 @@ commands =
commands = {posargs}
[flake8]
# E122 continuation line missing indentation or outdented
# E125 continuation line does not distinguish itself from next logical line
# E126 continuation line over-indented for hanging indent
# E128 continuation line under-indented for visual indent
@ -62,7 +61,7 @@ commands = {posargs}
# H405 multi line docstring summary not separated with an empty line
# H904 Wrap long lines in parentheses instead of a backslash
# TODO(marun) H404 multi line docstring should start with a summary
ignore = E122,E125,E126,E128,E129,E251,E265,E713,F402,F811,F812,H104,H237,H302,H304,H305,H307,H401,H402,H404,H405,H904
ignore = E125,E126,E128,E129,E251,E265,E713,F402,F811,F812,H104,H237,H302,H304,H305,H307,H401,H402,H404,H405,H904
show-source = true
builtins = _
exclude = .venv,.git,.tox,dist,doc,*openstack/common*,*lib/python*,*egg,build,tools,.ropeproject