openstack/neutron
Code Issues Proposed changes

Don't check full subnet body in test_filtering_shared_subnets

Browse Source 
Plugins may add attributes to subnets, in which case simple equality
check will fail. Instead of comparing bodies, compare just IDs. It
should be enough to achieve the goal of the test case.

Change-Id: Iebc22f99285777df7de499c713b2bc1e38e0bd62
Closes-Bug: #1706986
This commit is contained in:
Ihar Hrachyshka 2017-08-03 12:52:32 -07:00 committed by garyk
parent 12d6a3ea4c
commit 242b63be23
1 changed files with 14 additions and 11 deletions

25
neutron/tests/tempest/api/admin/test_shared_network_extension.py

@ -65,19 +65,22 @@ class SharedNetworksTest(base.BaseAdminNetworkTest):
client=self.admin_client)
self.assertIn(shared['id'],
self._list_subnets_ids(self.client, shared=True))
self.assertIn(shared,
self.admin_client.list_subnets(shared=True)['subnets'])
self.assertNotIn(priv,
self.client.list_subnets(shared=True)['subnets'])
self.assertNotIn(priv,
self.admin_client.list_subnets(shared=True)['subnets'])
self.assertIn(priv, self.client.list_subnets(shared=False)['subnets'])
self.assertIn(shared['id'],
self._list_subnets_ids(self.admin_client, shared=True))
self.assertNotIn(priv['id'],
self._list_subnets_ids(self.client, shared=True))
self.assertNotIn(
priv['id'],
self._list_subnets_ids(self.admin_client, shared=True))
self.assertIn(priv['id'],
self._list_subnets_ids(self.client, shared=False))
self.assertIn(priv['id'],
self._list_subnets_ids(self.admin_client, shared=False))
self.assertNotIn(shared,
self.client.list_subnets(shared=False)['subnets'])
self.assertNotIn(shared,
self.admin_client.list_subnets(shared=False)['subnets'])
self.assertNotIn(shared['id'],
self._list_subnets_ids(self.client, shared=False))
self.assertNotIn(
shared['id'],
self._list_subnets_ids(self.admin_client, shared=False))
@decorators.idempotent_id('6661d219-b96d-4597-ad10-55766ce4abf7')
def test_create_update_shared_network(self):