openstack/neutron
Code Issues Proposed changes

lbaas: check object state before update for pools, members, health monitors

Browse Source 
Fixes bug 1166365

Change-Id: I027bb1465ab08a643a02bddea30db82652be55ed
This commit is contained in:
Oleg Bondarev 2013-04-11 16:56:08 +04:00 committed by Gerrit Code Review
parent 11639a2642
commit 26b98b7b51
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
quantum/db/loadbalancer/loadbalancer_db.py
View File

@ -547,6 +547,7 @@ class LoadBalancerPluginDb(LoadBalancerPluginBase):
with context.session.begin(subtransactions=True):
pool_db = self._get_resource(context, Pool, id)
self.assert_modification_allowed(pool_db)
if p:
pool_db.update(p)
@ -680,6 +681,7 @@ class LoadBalancerPluginDb(LoadBalancerPluginBase):
v = member['member']
with context.session.begin(subtransactions=True):
member_db = self._get_resource(context, Member, id)
self.assert_modification_allowed(member_db)
if v:
member_db.update(v)
@ -740,6 +742,7 @@ class LoadBalancerPluginDb(LoadBalancerPluginBase):
v = health_monitor['health_monitor']
with context.session.begin(subtransactions=True):
monitor_db = self._get_resource(context, HealthMonitor, id)
self.assert_modification_allowed(monitor_db)
if v:
monitor_db.update(v)
return self._make_health_monitor_dict(monitor_db)