openstack/neutron
Code Issues Proposed changes

[OVS] Avoid duplicate logging of network packets

Browse Source 
We have 2 classes inheriting from BaseNeutronAgentOSKenApp:
OVSNeutronAgentOSKenApp and OVSLogOSKenApp. The instantiation of
packet_in_handlers as a static property in BaseNeutronAgentOSKenApp
created a shared list between all the different objects created by the
inheriting classes. This ended up creating duplicated processing of
events and therefore duplicate logging in the ML2/OVS log API.

Closes-Bug: #2121961

Change-Id: I6c37fbed8d724b7215ca21d155dde00e1229c6ea
Signed-off-by: Elvira Garcia <egarciar@redhat.com>
This commit is contained in:
Elvira Garcia
2025-10-21 17:05:57 +02:00
parent 3969739c9f
commit 29f4ada315
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
neutron/plugins/ml2/drivers/openvswitch/agent/openflow/native/base_oskenapp.py
View File

@@ -24,7 +24,10 @@ LOG = logging.getLogger(__name__)
class BaseNeutronAgentOSKenApp(app_manager.OSKenApp): class BaseNeutronAgentOSKenApp(app_manager.OSKenApp):
OFP_VERSIONS = [ofproto_v1_3.OFP_VERSION] OFP_VERSIONS = [ofproto_v1_3.OFP_VERSION]
packet_in_handlers = []
def __init__(self):
super().__init__()
self.packet_in_handlers = []
def register_packet_in_handler(self, caller): def register_packet_in_handler(self, caller):
self.packet_in_handlers.append(caller) self.packet_in_handlers.append(caller)