openstack
/
neutron
Code Issues Proposed changes

Use switch-case instead of if-then-elif 

Make the gate hook more compact and align if statement
syntax.

Change-Id: I879bf097f3f54bff83408299b39f5dcfc298adba
This commit is contained in:
Armando Migliaccio 2016-04-16 08:35:12 -07:00
parent 8a5514ce66
commit 2d2bb27444
1 changed files with 13 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
neutron/tests/contrib/gate_hook.sh
View File

@ -29,8 +29,8 @@ function load_conf_hook {
}
if [ "$VENV" == "dsvm-functional" ] || [ "$VENV" == "dsvm-fullstack" ]
then
case $VENV in
"dsvm-functional"|"dsvm-fullstack")
# The following need to be set before sourcing
# configure_for_func_testing.
GATE_STACK_USER=stack
@ -60,16 +60,20 @@ then
# Make the workspace owned by the stack user
sudo chown -R $STACK_USER:$STACK_USER $BASE
;;
elif [ "$VENV" == "api" -o "$VENV" == "api-pecan" -o "$VENV" == "full-pecan" -o "$VENV" == "dsvm-scenario" ]
then
"api"|"api-pecan"|"full-pecan"|"dsvm-scenario")
load_rc_hook api_extensions
if [ "$VENV" == "api-pecan" -o "$VENV" == "full-pecan" ]
then
load_conf_hook pecan
fi
load_rc_hook qos
load_rc_hook bgp
if [[ "$VENV" =~ "pecan" ]]; then
load_conf_hook pecan
fi
$BASE/new/devstack-gate/devstack-vm-gate.sh
fi
;;
*)
echo "Unrecognized environment $VENV".
exit 1
esac