Browse Source

Do not assume order of network_uuid's

This fixes the neutron.tests.unit.test_linux_dhcp.TestDnsmasq
.test_existing_dhcp_networks unit test that breaks with a
randomized PYTHONHASHSEED (see the bug report).

The test assumed that the network_uuid's list was sorted, so sort
the result before comparing.

Note: There are several other unrelated unit tests that also break with a
randomized PYTHONHASHSEED, but they are not addressed here. They will be
addressed in separate patches.

Partial-bug: #1348818
Change-Id: Ia6f742e1fae0687164b841beebb4efcf31ff2625
changes/22/111822/2
Pritesh Kothari 8 years ago committed by pritesh
parent
commit
31783e2eae
  1. 2
      neutron/tests/unit/test_linux_dhcp.py

2
neutron/tests/unit/test_linux_dhcp.py

@ -1316,7 +1316,7 @@ tag:tag0,option:router""".lstrip()
mock_listdir.assert_called_once_with(path)
self.assertEqual(['aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa',
'bbbbbbbb-bbbb-bbbb-bbbb-bbbbbbbbbbbb'],
result)
sorted(result))
def _check_version(self, cmd_out, expected_value):
with mock.patch('neutron.agent.linux.utils.execute') as cmd:

Loading…
Cancel
Save