openstack
/
neutron
Code Issues Proposed changes

Merge "Add short info about tempest API/scenario tests to reviewers guide"

This commit is contained in:
Zuul 2019-05-30 20:40:03 +00:00 committed by Gerrit Code Review
parent 8a02675582 d55d3bb9f1
commit 36428d60a6
1 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
doc/source/contributor/policies/code-reviews.rst
View File

@ -80,6 +80,21 @@ In addition to that, the following rules are to follow:
When impacts are identified as a result of the above steps, every effort must
be made to work with the affected sub-projects to resolve the issues.
* Any change that modifies or introduces a new API should have test coverage in
neutron-tempest-plugin or tempest test suites. There should be at least one
API test added for a new feature, but it is preferred that both API and
scenario tests be added where it is appropriate.
Scenario tests should cover not only the base level of new functionality, but
also standard ways in which the functionality can be used. For example, if the
feature adds a new kind of networking (like e.g. trunk ports) then tests
should make sure that instances can use IPs provided by that networking,
can be migrated, etc.
It is also preferred that some negative test cases, like API tests to
ensure that correct HTTP error is returned when wrong data is provided,
will be added where it is appropriate.
.. _spec-review-practices:
Neutron Spec Review Practices