openstack
/
neutron
Code Issues Proposed changes

Fixing the syntax error in the XML Serializer 

This commit fixes the syntax error in the XML Serializer.
Modified wsgi test to exercise this bit of code as well

Fixes: Bug #1158468
Change-Id: I1bff589a46ff4884e131d7cf60551e2f400acb67
This commit is contained in:
Arvind Somya 2013-03-21 12:18:20 -07:00
parent 1eab8cb6f5
commit 3cf9c8c97a
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
quantum/tests/unit/test_wsgi.py
View File

@ -186,16 +186,18 @@ class SerializerTest(base.BaseTestCase):
"""
content_type = 'application/xml'
data_string = (
'<servers xmlns="fake">'
'<servers>'
'<server name="s1">'
'<test test="a">passed</test>'
'</server>'
'</servers>'
)
metadata = {'plurals': ['servers', 'test'], 'xmlns': 'fake'}
metadata = {'plurals': {'servers': 'server'}, 'xmlns': 'fake'}
serializer = wsgi.Serializer(
default_xmlns="fake", metadata=metadata)
result = serializer.deserialize(data_string, content_type)
expected = {'body': {'servers': ['passed']}}
expected = {'body': {'servers': [{'name': 's1', 'test': 'passed'}]}}
self.assertEqual(expected, result)

2
quantum/wsgi.py
View File

@ -583,7 +583,7 @@ class XMLDeserializer(TextDeserializer):
attr == constants.XSI_ATTR or
attr == constants.TYPE_ATTR):
continue
result[self._get_key(attr)] = node.get[attr]
result[self._get_key(attr)] = node.get(attr)
children = list(node)
for child in children:
result[self._get_key(child.tag)] = self._from_xml_node(