diff --git a/neutron/tests/unit/agent/common/test_resource_processing_queue.py b/neutron/tests/unit/agent/common/test_resource_processing_queue.py index 3b66a257519..7ec218f4e2c 100644 --- a/neutron/tests/unit/agent/common/test_resource_processing_queue.py +++ b/neutron/tests/unit/agent/common/test_resource_processing_queue.py @@ -100,7 +100,7 @@ class TestExclusiveResourceProcessor(base.BaseTestCase): for update in not_primary.updates(): raise Exception("Only the primary should process a resource") - self.assertEqual(2, len([i for i in primary.updates()])) + self.assertEqual(2, len(list(primary.updates()))) def test_hit_retry_limit(self): tries = 1 diff --git a/neutron/tests/unit/extensions/test_l3.py b/neutron/tests/unit/extensions/test_l3.py index 14039edf56a..89ef3e97f7a 100644 --- a/neutron/tests/unit/extensions/test_l3.py +++ b/neutron/tests/unit/extensions/test_l3.py @@ -4066,7 +4066,7 @@ class L3AgentDbTestCaseBase(L3NatTestCaseMixin): with mock.patch(l3_rpc_agent_api_str): plugin = directory.get_plugin(plugin_constants.L3) notifyApi = plugin.l3_rpc_notifier - kargs = [item for item in args] + kargs = list(args) kargs.append(notifyApi) target_func(*kargs) diff --git a/neutron/tests/unit/extensions/test_subnetpool_prefix_ops.py b/neutron/tests/unit/extensions/test_subnetpool_prefix_ops.py index dbb3c278375..84e38073f55 100644 --- a/neutron/tests/unit/extensions/test_subnetpool_prefix_ops.py +++ b/neutron/tests/unit/extensions/test_subnetpool_prefix_ops.py @@ -206,7 +206,7 @@ class SubnetpoolPrefixOpsTestBase(object): subnetpool = subnetpool_obj.SubnetPool.get_object( self.context, id=subnetpool_id) - current_prefix_set = netaddr.IPSet([x for x in subnetpool.prefixes]) + current_prefix_set = netaddr.IPSet(list(subnetpool.prefixes)) expected_prefix_set = netaddr.IPSet(expected_prefixes) excluded_prefix_set = netaddr.IPSet(excluded_prefixes) self.assertTrue(expected_prefix_set.issubset(current_prefix_set)) diff --git a/neutron/tests/unit/scheduler/test_dhcp_agent_scheduler.py b/neutron/tests/unit/scheduler/test_dhcp_agent_scheduler.py index 0ebae7dfdc5..e1cc9b346ec 100644 --- a/neutron/tests/unit/scheduler/test_dhcp_agent_scheduler.py +++ b/neutron/tests/unit/scheduler/test_dhcp_agent_scheduler.py @@ -528,7 +528,7 @@ class TestNetworksFailover(TestDhcpSchedulerBaseTestCase, with mock.patch.object(self, 'agent_starting_up', side_effect=[True, False]): - res = [b for b in self._filter_bindings(None, bindings_objs)] + res = list(self._filter_bindings(None, bindings_objs)) # once per each agent id1 and id2 self.assertEqual(2, len(res)) res_ids = [b.network_id for b in res]