openstack/neutron
Code Issues Proposed changes

Fix negative unit test for sec group rules

Browse Source 
Ensure the test fails because the security group
rule could not be created, and not because the security
group was deleted before creating the rule.

Closes-Bug: #1268561

Change-Id: Ib2ea8c4507862d7bb343ce5181cf018b3cdf4b73
This commit is contained in:
Salvatore Orlando 2014-01-13 03:33:40 -08:00
parent ab1f474ace
commit 45557c43e4
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
neutron/tests/unit/test_extension_security_group.py
View File

@ -738,9 +738,11 @@ class TestSecurityGroups(SecurityGroupDBTestCase):
'port_range_max': '22', 'port_range_max': '22',
'tenant_id': "bad_tenant"}} 'tenant_id': "bad_tenant"}}
res = self._create_security_group_rule(self.fmt, rule) res = self._create_security_group_rule(self.fmt, rule,
self.deserialize(self.fmt, res) tenant_id='bad_tenant',
self.assertEqual(res.status_int, webob.exc.HTTPNotFound.code) set_context=True)
self.deserialize(self.fmt, res)
self.assertEqual(res.status_int, webob.exc.HTTPNotFound.code)
def test_create_security_group_rule_bad_tenant_remote_group_id(self): def test_create_security_group_rule_bad_tenant_remote_group_id(self):
with self.security_group() as sg: with self.security_group() as sg: