openstack/neutron
Code Issues Proposed changes

Use local and ip address to create vxlan interface

Browse Source 
Attempting to terminate a vxlan on the lo interface with
multiple ip addresses fails. This seems to be because only
the first ip address on the interface is used. If this address
is invalid for vxlan creation (ie. 127.0.0.1), the vxlan
interface will be created, but will not have a source ip
address, and will therefore be non-functional. To remedy this
issue, when L2population is used, we can set the local
argument to the local_ip, thus ensuring the intended ip
address is configured.

Closes-Bug: 1929998
Change-Id: I9c54a268fc4ef9705637556ecba161bd6523a047
Signed-off-by: Anthony Timmins <atimmins@datto.com>
This commit is contained in:
Anthony Timmins 2021-05-27 16:11:04 -04:00
parent 5a6f61af4a
commit 4cd11f4dee
2 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
neutron/plugins/ml2/drivers/linuxbridge/agent/linuxbridge_neutron_agent.py
View File

@ -346,8 +346,12 @@ class LinuxBridgeManager(amb.CommonAgentManagerBase):
if self.vxlan_mode == lconst.VXLAN_MCAST:
args['group'] = self.get_vxlan_group(segmentation_id)
if cfg.CONF.VXLAN.l2_population:
args['proxy'] = cfg.CONF.VXLAN.arp_responder
# L2population should set the local ip address to handle
# a source dev with multiple ip addresses configured.
args['local'] = self.local_ip
try:
int_vxlan = self.ip.add_vxlan(interface, segmentation_id,

1
neutron/tests/unit/plugins/ml2/drivers/linuxbridge/agent/test_linuxbridge_neutron_agent.py
View File

@ -412,6 +412,7 @@ class TestLinuxBridgeManager(base.BaseTestCase):
dstport=None,
ttl=None,
dev=self.lbm.local_int,
local=self.lbm.local_ip,
proxy=expected_proxy)
def test_ensure_vxlan_arp_responder_enabled(self):