openstack/neutron
Code Issues Proposed changes

Revert "Mute neutron.callbacks notification logs."

Browse Source 
This reverts commit e19eb49c1c.

We don't use callbacks to extend resources, so no need to mute the logs.

Change-Id: I8eaffa243f74a8f93dfc1638727ac9cd0bdf505d
This commit is contained in:
Ihar Hrachyshka 2015-07-22 12:53:00 +02:00
parent d3708de0cb
commit 517cf5b843
1 changed files with 3 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
neutron/callbacks/manager.py
View File

@ -131,22 +131,14 @@ class CallbacksManager(object):
def _notify_loop(self, resource, event, trigger, **kwargs): def _notify_loop(self, resource, event, trigger, **kwargs):
"""The notification loop.""" """The notification loop."""
LOG.debug("Notify callbacks for %(resource)s, %(event)s",
#TODO(QoS): we found callback logs happening in the middle {'resource': resource, 'event': event})
# of transactions being a source of DBDeadLocks
# because they can yield. (Can LOG writes yield?,
# please revisit this).
#
#LOG.debug("Notify callbacks for %(resource)s, %(event)s",
# {'resource': resource, 'event': event})
errors = [] errors = []
# TODO(armax): consider using a GreenPile # TODO(armax): consider using a GreenPile
for callback_id, callback in self._callbacks[resource][event].items(): for callback_id, callback in self._callbacks[resource][event].items():
try: try:
#TODO(QoS): muting logs for the reasons explained in the LOG.debug("Calling callback %s", callback_id)
# previous TODO(QoS)
#LOG.debug("Calling callback %s", callback_id)
callback(resource, event, trigger, **kwargs) callback(resource, event, trigger, **kwargs)
except Exception as e: except Exception as e:
LOG.exception(_LE("Error during notification for " LOG.exception(_LE("Error during notification for "