From 546b796f43ed535056407a3c9fe77f0720c1510d Mon Sep 17 00:00:00 2001 From: Brian Haley Date: Mon, 4 Mar 2024 15:53:13 -0500 Subject: [PATCH] Increase code coverage for ip_lib sysctl() Noticed there were no "get" sysctl tests in cover output, add two simple ones. TrivialFix Change-Id: Id819ae9d61c9d831d38efa0153b45d13a96a7d1e --- neutron/tests/unit/agent/linux/test_ip_lib.py | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/neutron/tests/unit/agent/linux/test_ip_lib.py b/neutron/tests/unit/agent/linux/test_ip_lib.py index 159cafdb8e5..6624294d09d 100644 --- a/neutron/tests/unit/agent/linux/test_ip_lib.py +++ b/neutron/tests/unit/agent/linux/test_ip_lib.py @@ -1177,6 +1177,24 @@ class TestSysctl(base.BaseTestCase): self.assertFalse(self.execute.called) +class TestGetSysctl(base.BaseTestCase): + @mock.patch.object(ip_lib, 'IPWrapper') + def test_get_ip_nonlocal_bind(self, mIPWrapper): + cmd = ['sysctl', '-bn', ip_lib.IP_NONLOCAL_BIND] + ip_lib.get_ip_nonlocal_bind() + mIPWrapper.assert_has_calls([ + mock.call().netns.execute(cmd, run_as_root=True, privsep_exec=True) + ]) + + @mock.patch.object(ip_lib, 'IPWrapper') + def test_get_ipv6_forwarding(self, mIPWrapper): + cmd = ['sysctl', '-b', 'net.ipv6.conf.tap0.forwarding'] + ip_lib.get_ipv6_forwarding('tap0') + mIPWrapper.assert_has_calls([ + mock.call().netns.execute(cmd, run_as_root=True, privsep_exec=True) + ]) + + class TestConntrack(base.BaseTestCase): def setUp(self): super(TestConntrack, self).setUp()