openstack
/
neutron
Code Issues Proposed changes

ovs: improve log message when ofport is not configured 

This switch the warning to error as we may be in a sitation of no
connectivity and this should never happen.

Also improves the condition for an ofport invalid.

Signed-off-by: Sahid Orentino Ferdjaoui <sahid.ferdjaoui@industrialdiscipline.com>
Change-Id: Ic6bd7bfadcba8deb132d8af3e295ec25a8d64b50
This commit is contained in:
Sahid Orentino Ferdjaoui 2022-07-18 11:43:50 +02:00
parent 3ffbf831cf
commit 5848c0dd1c
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py
View File

@ -1848,10 +1848,10 @@ class OVSNeutronAgent(l2population_rpc.L2populationRpcCallBackTunnelMixin,
# for being treated. If that does not happen, it is a potential
# error condition of which operators should be aware
port_needs_binding = True
if not vif_port.ofport:
LOG.warning("VIF port: %s has no ofport configured, "
"and might not be able to transmit",
vif_port.vif_id)
if not vif_port.ofport or vif_port.ofport == ovs_lib.INVALID_OFPORT:
LOG.error("VIF port: %s has no ofport configured or is invalid, "
"and might not be able to transmit. (ofport=%s)",
vif_port.vif_id, vif_port.ofport)
if vif_port:
if admin_state_up:
port_needs_binding = self.port_bound(