From f6006d73ee075e03982936301417030c23f92c86 Mon Sep 17 00:00:00 2001 From: Jakub Libosvar Date: Wed, 23 Mar 2022 13:34:14 -0400 Subject: [PATCH] ovn migration: Turn validations off by default The validation is intended mostly for tests and don't make much sense when running the migration in production because likely there are already running workloads. This patch changes the default to False so migration validation must be explicitly asked for. Change-Id: I5470f61a5e0b55bf682526208c3f57dc0ca6ffd5 Signed-off-by: Jakub Libosvar (cherry picked from commit 0baf8841eea402b7b8505ee685b1ac1a3f346df5) --- doc/source/ovn/migration.rst | 2 +- ...change-migration-validation-b030b02c5e1acd3d.yaml | 12 ++++++++++++ .../tripleo_environment/ovn_migration.sh | 2 +- 3 files changed, 14 insertions(+), 2 deletions(-) create mode 100644 releasenotes/notes/change-migration-validation-b030b02c5e1acd3d.yaml diff --git a/doc/source/ovn/migration.rst b/doc/source/ovn/migration.rst index 14ad24e89f7..577afc24f99 100644 --- a/doc/source/ovn/migration.rst +++ b/doc/source/ovn/migration.rst @@ -136,7 +136,7 @@ Perform the following steps in the undercloud * VALIDATE_MIGRATION - Create migration resources to validate the migration. The migration script, before starting the migration, boot a server and validates that the server is reachable after the migration. - Default: True. + Default: False * SERVER_USER_NAME - User name to use for logging into the migration instances. diff --git a/releasenotes/notes/change-migration-validation-b030b02c5e1acd3d.yaml b/releasenotes/notes/change-migration-validation-b030b02c5e1acd3d.yaml new file mode 100644 index 00000000000..94aa5e319c3 --- /dev/null +++ b/releasenotes/notes/change-migration-validation-b030b02c5e1acd3d.yaml @@ -0,0 +1,12 @@ +--- +other: + - | + The OVN migration performs validation by default. This validation means an + instance is spawned and is tested by simple ping after the migration is + finished. Also it tries to create new workload post migration. This is + useful for very simple scenarios when migration is tested but is not + really useful in production since likely the production envrionments + already have running workloads. It makes more sense to require the + validation explicitly rather than implicitly run it as the migration + is mostly intended for production. The VALIDATE_MIGRATION now defaults to + False and needs to be changed to True if validation upon request. diff --git a/tools/ovn_migration/tripleo_environment/ovn_migration.sh b/tools/ovn_migration/tripleo_environment/ovn_migration.sh index 0a71b1a7619..e3ba6a8a313 100644 --- a/tools/ovn_migration/tripleo_environment/ovn_migration.sh +++ b/tools/ovn_migration/tripleo_environment/ovn_migration.sh @@ -38,7 +38,7 @@ LANG=C : ${PUBLIC_NETWORK_NAME:=public} : ${IMAGE_NAME:=cirros} : ${SERVER_USER_NAME:=cirros} -: ${VALIDATE_MIGRATION:=True} +: ${VALIDATE_MIGRATION:=False} : ${DHCP_RENEWAL_TIME:=30} : ${CREATE_BACKUP:=True} : ${BACKUP_MIGRATION_IP:=192.168.24.1} # TODO: Document this new var