openstack/neutron
Code Issues Proposed changes

Merge "Hacking: add unit test for LOG.warn validations"

Browse Source
This commit is contained in:
Jenkins 2016-08-17 05:26:37 +00:00 committed by Gerrit Code Review
commit 6449c40108
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
neutron/tests/unit/hacking/test_checks.py
View File

@ -334,6 +334,11 @@ class HackingTestCase(base.BaseTestCase):
0, len(list(checks.check_delayed_string_interpolation(fail_code1, 0, len(list(checks.check_delayed_string_interpolation(fail_code1,
"neutron/common/rpc.py", dummy_noqa)))) "neutron/common/rpc.py", dummy_noqa))))
def test_check_log_warn_deprecated(self):
bad = "LOG.warn(_LW('i am zlatan!'))"
self.assertEqual(
1, len(list(checks.check_log_warn_deprecated(bad, 'f'))))
# The following is borrowed from hacking/tests/test_doctest.py. # The following is borrowed from hacking/tests/test_doctest.py.
# Tests defined in docstring is easier to understand # Tests defined in docstring is easier to understand
# in some cases, for example, hacking rules which take tokens as argument. # in some cases, for example, hacking rules which take tokens as argument.