openstack/neutron
Code Issues Proposed changes

Add debug information to `MacvtapAgentTestCase.test_get_all_devices`

Browse Source 
This patch is also adding an active wait checking both the MacVTap
device MAC address and the list of MAC addresses returned by the
MacVTAP manager.

Related-Bug: #2012510
Change-Id: I13d4a76572af050ee07fbb2b9fe2abd60d337955
(cherry picked from commit 775d5de9f1)
This commit is contained in:
Rodolfo Alonso Hernandez 2023-03-29 20:16:35 +02:00 committed by yatinkarel
parent 9de68a7408
commit 65be5a940b
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
neutron/tests/functional/plugins/ml2/drivers/macvtap/agent/test_macvtap_neutron_agent.py
View File

@ -17,6 +17,7 @@
from neutron_lib import constants
from neutron.agent.linux import ip_lib
from neutron.common import utils as common_utils
from neutron.plugins.ml2.drivers.macvtap.agent import macvtap_neutron_agent
from neutron.tests.common import net_helpers
from neutron.tests.functional import base as functional_base
@ -44,5 +45,14 @@ class MacvtapAgentTestCase(functional_base.BaseSudoTestCase):
macvtap = self.useFixture(net_helpers.MacvtapFixture(
src_dev=veth1.name, mode='bridge',
prefix=constants.MACVTAP_DEVICE_PREFIX)).ip_dev
self.assertEqual(set([macvtap.link.address]),
self.mgr.get_all_devices())
try:
common_utils.wait_until_true(
lambda: {macvtap.link.address} == self.mgr.get_all_devices(),
timeout=5)
except common_utils.WaitTimeout:
msg = 'MacVTap address: %s, read devices: %s\n' % (
macvtap.link.address, self.mgr.get_all_devices())
for device in ip_lib.IPWrapper().get_devices():
msg += ' Device %s, MAC: %s' % (device.name,
device.link.address)
self.fail(msg)