openstack
/
neutron
Code Issues Proposed changes

Avoid creating FixedIntervalLoopingCall in agent UT 

Set polling_interval to 0 to avoid creating LoopingCall
in loadbalancer agent tests, dhcp agent tests, linuxbridge agent tests

Change-Id: Ib6edbc11feba402a4c2f19b7d6833b49879ee626
Closes-Bug: #1288079
This commit is contained in:
Eugene Nikanorov 2014-03-11 16:04:49 +04:00 committed by Gerrit Code Review
parent 386aa20710
commit 712923d3ab
3 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
neutron/tests/unit/linuxbridge/test_lb_neutron_agent.py
View File

@ -96,6 +96,8 @@ class TestLinuxBridgeAgent(base.BaseTestCase):
def setUp(self):
super(TestLinuxBridgeAgent, self).setUp()
# disable setting up periodic state reporting
cfg.CONF.set_override('report_interval', 0, 'AGENT')
cfg.CONF.set_override('rpc_backend',
'neutron.openstack.common.rpc.impl_fake')
self.execute_p = mock.patch.object(ip_lib.IPWrapper, '_execute')

3
neutron/tests/unit/services/loadbalancer/agent/test_agent_manager.py
View File

@ -38,6 +38,9 @@ class TestManager(base.BaseTestCase):
'neutron.services.loadbalancer.agent.agent_api.LbaasAgentApi'
).start()
# disable setting up periodic state reporting
mock_conf.AGENT.report_interval = 0
self.mgr = manager.LbaasAgentManager(mock_conf)
self.rpc_mock = rpc_mock_cls.return_value
self.log = mock.patch.object(manager, 'LOG').start()

5
neutron/tests/unit/test_dhcp_agent.py
View File

@ -132,6 +132,9 @@ class TestDhcpAgent(base.BaseTestCase):
dhcp_agent.register_options()
cfg.CONF.set_override('interface_driver',
'neutron.agent.linux.interface.NullDriver')
# disable setting up periodic state reporting
cfg.CONF.set_override('report_interval', 0, 'AGENT')
self.driver_cls_p = mock.patch(
'neutron.agent.dhcp_agent.importutils.import_class')
self.driver = mock.Mock(name='driver')
@ -143,6 +146,8 @@ class TestDhcpAgent(base.BaseTestCase):
def test_dhcp_agent_manager(self):
state_rpc_str = 'neutron.agent.rpc.PluginReportStateAPI'
# sync_state is needed for this test
cfg.CONF.set_override('report_interval', 1, 'AGENT')
with mock.patch.object(DhcpAgentWithStateReport,
'sync_state',
autospec=True) as mock_sync_state: