openstack
/
neutron
Code Issues Proposed changes

Move pylint disable comment to an effective place 

Bug #1893316 still occurs, e.g.:
https://zuul.opendev.org/t/openstack/build/94dc9db2fee049b38926827e97bbec09

after the attempted fix:
https://review.opendev.org/748594

I believe the attempted fix was basically good, but in order to disable
the pylint warning for the whole method the comment must be placed
in the method body, not on the signature line.

Change-Id: I55c6daf976c62252aca403358b824d4d3aaa495c
Closes-Bug: #1893316
Related-Change: Iba4f2ea700f01fd153104741614eec4855d0f387
This commit is contained in:
Bence Romsics 2020-09-01 16:50:40 +02:00
parent d189d83bd7
commit 72b3fc5745
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
neutron/agent/linux/dhcp.py
View File

@ -136,7 +136,8 @@ class DictModel(collections.abc.MutableMapping):
def __copy__(self):
return type(self)(self)
def __deepcopy__(self, memo): # pylint: disable=no-value-for-parameter
def __deepcopy__(self, memo):
# pylint: disable=no-value-for-parameter
cls = self.__class__
result = cls.__new__(cls)
memo[id(self)] = result