openstack/neutron
Code Issues Proposed changes

Removed unnecessary setUp calls in tests

Browse Source 
There are several places where base class setUp() method call was
called unnecessary. In this patchset, they are removed.

TrivialFix

Change-Id: I2961fa4a0216f7f1223ab87a249151f0feb91518
This commit is contained in:
Gábor Antal 2017-07-31 17:13:34 +02:00
parent 58e5a6c64e
commit 789acb3a7e
9 changed files with 0 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
neutron/tests/unit/agent/l3/test_fip_rule_priority_allocator.py
View File

@ -17,9 +17,6 @@ from neutron.tests import base
class TestFipPriority(base.BaseTestCase):
def setUp(self):
super(TestFipPriority, self).setUp()
def test__init__(self):
test_pr = frpa.FipPriority(10)
self.assertEqual(10, test_pr.index)

2
neutron/tests/unit/agent/l3/test_ha_router.py
View File

@ -25,8 +25,6 @@ _uuid = uuidutils.generate_uuid
class TestBasicRouterOperations(base.BaseTestCase):
def setUp(self):
super(TestBasicRouterOperations, self).setUp()
def _create_router(self, router=None, **kwargs):
if not router:

2
neutron/tests/unit/agent/l3/test_item_allocator.py
View File

@ -28,8 +28,6 @@ class TestObject(object):
class TestItemAllocator(base.BaseTestCase):
def setUp(self):
super(TestItemAllocator, self).setUp()
def test__init__(self):
test_pool = set(TestObject(s) for s in range(32768, 40000))

2
neutron/tests/unit/agent/l3/test_router_processing_queue.py
View File

@ -26,8 +26,6 @@ FAKE_ID_2 = _uuid()
class TestExclusiveRouterProcessor(base.BaseTestCase):
def setUp(self):
super(TestExclusiveRouterProcessor, self).setUp()
def test_i_am_master(self):
master = l3_queue.ExclusiveRouterProcessor(FAKE_ID)

3
neutron/tests/unit/agent/linux/test_interface.py
View File

@ -595,9 +595,6 @@ class TestBridgeInterfaceDriver(TestBase):
class TestIVSInterfaceDriver(TestBase):
def setUp(self):
super(TestIVSInterfaceDriver, self).setUp()
def test_get_device_name(self):
br = interface.IVSInterfaceDriver(self.conf)
device_name = br.get_device_name(FakePort())

3
neutron/tests/unit/agent/linux/test_iptables_firewall.py
View File

@ -2091,9 +2091,6 @@ class IptablesFirewallEnhancedIpsetTestCase(BaseIptablesFirewallTestCase):
class OVSHybridIptablesFirewallTestCase(BaseIptablesFirewallTestCase):
def setUp(self):
super(OVSHybridIptablesFirewallTestCase, self).setUp()
def test__populate_initial_zone_map(self):
self.assertEqual(self._dev_zone_map,
self.firewall.ipconntrack._device_zone_map)

3
neutron/tests/unit/api/rpc/callbacks/consumer/test_registry.py
View File

@ -18,9 +18,6 @@ from neutron.tests import base
class ConsumerRegistryTestCase(base.BaseTestCase):
def setUp(self):
super(ConsumerRegistryTestCase, self).setUp()
def test__get_manager_is_singleton(self):
self.assertIs(registry._get_manager(), registry._get_manager())

3
neutron/tests/unit/extensions/test_timestamp.py
View File

@ -240,9 +240,6 @@ class TimeStampChangedsinceTestCase(test_db_base_plugin_v2.
class TimeStampDBMixinTestCase(TimeStampChangedsinceTestCase):
"""Test timestamp_db.TimeStamp_db_mixin()"""
def setUp(self):
super(TimeStampDBMixinTestCase, self).setUp()
def _save_network(self, network_id):
ctx = context.get_admin_context()
with ctx.session.begin(subtransactions=True):

3
neutron/tests/unit/ipam/test_requests.py
View File

@ -187,9 +187,6 @@ class TestAddressRequest(base.BaseTestCase):
EUI64 = ipam_req.AutomaticAddressRequest.EUI64
def setUp(self):
super(TestAddressRequest, self).setUp()
def test_specific_address_ipv6(self):
request = ipam_req.SpecificAddressRequest('2000::45')
self.assertEqual(netaddr.IPAddress('2000::45'), request.address)