openstack
/
neutron
Code Issues Proposed changes

BSN: Set hash header to empty instead of False 

Sets the consistency hash header to empty instead
of False since 'False' is handled like a string on
the backend and requires special-casing to detect.

Closes-Bug: #1325771
Change-Id: Iee1651574c01a32e78167a9bbed4e0433abbdec2
This commit is contained in:
Kevin Benton 2014-06-01 22:43:02 -07:00
parent e65b06f458
commit 7b9ed4edee
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
neutron/plugins/bigswitch/servermanager.py
View File

@ -131,7 +131,7 @@ class ServerProxy(object):
headers['NeutronProxy-Agent'] = self.name
headers['Instance-ID'] = self.neutron_id
headers['Orchestration-Service-ID'] = ORCHESTRATION_SERVICE_ID
headers[HASH_MATCH_HEADER] = self.mypool.consistency_hash
headers[HASH_MATCH_HEADER] = self.mypool.consistency_hash or ''
if 'keep-alive' in self.capabilities:
headers['Connection'] = 'keep-alive'
else:

4
neutron/tests/unit/bigswitch/test_servermanager.py
View File

@ -102,8 +102,8 @@ class ServerManagerTests(test_rp.BigSwitchProxyPluginV2TestCase):
with self.network():
callheaders = rv.request.mock_calls[0][1][3]
self.assertIn('X-BSN-BVS-HASH-MATCH', callheaders)
# first call will be False to indicate no previous state hash
self.assertEqual(callheaders['X-BSN-BVS-HASH-MATCH'], False)
# first call will be empty to indicate no previous state hash
self.assertEqual(callheaders['X-BSN-BVS-HASH-MATCH'], '')
# change the header that will be received on delete call
rv.getresponse.return_value.getheader.return_value = 'HASH2'