openstack
/
neutron
Code Issues Proposed changes

Fix migration failed due TypeError of new_vlan_tag 

There could be a situation, when there are ports
with port_tags None created in OS infra.

Under normal circumstances, it would take some error
to the log and go further.
But only because there is a "new_vlan_tags must be string"
in that log, it is throwing out typeError and dropping
the execution of code and the migration is ending by code 500.

And this is all done without a message from
the log, which is extremely bad.

This patch is fixing this behaviour, and flow
goes on.

Change-Id: Id4ba8d32e6b2301f25c12f83a0708b62aa5b9d6d
Closes-Bug: #1903989
This commit is contained in:
Michal Arbet 2020-11-12 13:43:24 +01:00
parent 033a445fbf
commit 7cf52bb532
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py
View File

@ -1787,7 +1787,7 @@ class OVSNeutronAgent(l2population_rpc.L2populationRpcCallBackTunnelMixin,
LOG.info(
"Port '%(port_name)s' has lost "
"its vlan tag '%(vlan_tag)d'! "
"Current vlan tag on this port is '%(new_vlan_tag)d'.",
"Current vlan tag on this port is '%(new_vlan_tag)s'.",
{'port_name': port.port_name,
'vlan_tag': lvm.vlan,
'new_vlan_tag': port_tags[port.port_name]}