openstack
/
neutron
Code Issues Proposed changes

Use proper capitalization for OVS table names 

ovs-vsctl will convert the names for you, but native OVSDB won't.
It's always better to match case correctly when possible.

Partially-implemnts: blueprint vsctl-to-ovsdb
Change-Id: Ic782856446449a0296564cb6a0e6cf20d7ccfa7d
This commit is contained in:
Terry Wilson 2015-01-22 01:43:09 -06:00
parent ec3f7562e0
commit 8200f8004a
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
neutron/agent/linux/ovs_lib.py
View File

@ -155,7 +155,7 @@ class OVSBridge(BaseOVS):
check_error=True)
def set_protocols(self, protocols):
self.set_db_attribute('bridge', self.br_name, 'protocols', protocols,
self.set_db_attribute('Bridge', self.br_name, 'protocols', protocols,
check_error=True)
def create(self):

4
neutron/plugins/ibm/agent/sdnve_neutron_agent.py
View File

@ -146,7 +146,7 @@ class SdnveNeutronAgent(object):
if out_of_band:
LOG.debug("info_update received. New controller"
"is set to be out of band")
self.int_br.set_db_attribute("controller",
self.int_br.set_db_attribute("Controller",
self.int_bridge_name,
"connection-mode",
"out-of-band")
@ -175,7 +175,7 @@ class SdnveNeutronAgent(object):
if controller_ip:
int_br.set_controller(["tcp:" + controller_ip])
if out_of_band:
int_br.set_db_attribute("controller", bridge_name,
int_br.set_db_attribute("Controller", bridge_name,
"connection-mode", "out-of-band")
return int_br

2
neutron/tests/unit/agent/linux/test_ovs_lib.py
View File

@ -126,7 +126,7 @@ class OVS_Lib_Test(base.BaseTestCase):
def test_set_protocols(self):
protocols = 'OpenFlow13'
self.br.set_protocols(protocols)
self._verify_vsctl_mock('set', 'bridge', self.BR_NAME,
self._verify_vsctl_mock('set', 'Bridge', self.BR_NAME,
"protocols=%s" % protocols)
def test_create(self):