Fix misuse of assertTrue/assertFalse
Change-Id: I247705feeb71e20ad5260b0ca1da08de7290ba6e Closes-Bug: #1819982
This commit is contained in:
parent
add5347f9d
commit
86b3993cee
|
@ -167,7 +167,7 @@ class TestNovaNotify(base.BaseTestCase):
|
||||||
|
|
||||||
event = self.nova_notifier.create_port_changed_event(
|
event = self.nova_notifier.create_port_changed_event(
|
||||||
'create_floatingip', {}, returned_obj)
|
'create_floatingip', {}, returned_obj)
|
||||||
self.assertFalse(event, None)
|
self.assertIsNone(event)
|
||||||
|
|
||||||
def test_delete_floatingip_notify(self):
|
def test_delete_floatingip_notify(self):
|
||||||
device_id = '32102d7b-1cf4-404d-b50a-97aae1f55f87'
|
device_id = '32102d7b-1cf4-404d-b50a-97aae1f55f87'
|
||||||
|
@ -233,7 +233,7 @@ class TestNovaNotify(base.BaseTestCase):
|
||||||
'send_events') as send_events:
|
'send_events') as send_events:
|
||||||
self.nova_notifier.send_network_change('update_floatingip',
|
self.nova_notifier.send_network_change('update_floatingip',
|
||||||
{}, {})
|
{}, {})
|
||||||
self.assertFalse(send_events.called, False)
|
self.assertFalse(send_events.called)
|
||||||
|
|
||||||
@mock.patch('novaclient.client.Client')
|
@mock.patch('novaclient.client.Client')
|
||||||
def test_nova_send_events_returns_bad_list(self, mock_client):
|
def test_nova_send_events_returns_bad_list(self, mock_client):
|
||||||
|
|
|
@ -188,7 +188,7 @@ class PlacementReporterAgentsTestCases(test_plugin.Ml2PluginV2TestCase):
|
||||||
self.agents = plugin.PlacementReporterAgents(ml2_plugin=self.plugin)
|
self.agents = plugin.PlacementReporterAgents(ml2_plugin=self.plugin)
|
||||||
mech_driver = self.agents.mechanism_driver_by_agent_type(
|
mech_driver = self.agents.mechanism_driver_by_agent_type(
|
||||||
'test_mechanism_driver_agent')
|
'test_mechanism_driver_agent')
|
||||||
self.assertTrue(mech_driver, mechanism_test.TestMechanismDriver)
|
self.assertIsInstance(mech_driver, mechanism_test.TestMechanismDriver)
|
||||||
|
|
||||||
def test_mechanism_driver_by_agent_type_not_found(self):
|
def test_mechanism_driver_by_agent_type_not_found(self):
|
||||||
self.agents = plugin.PlacementReporterAgents(ml2_plugin=self.plugin)
|
self.agents = plugin.PlacementReporterAgents(ml2_plugin=self.plugin)
|
||||||
|
|
Loading…
Reference in New Issue