openstack/neutron
Code Issues Proposed changes

Merge "Fix misuse of assertTrue/assertFalse"

Browse Source
This commit is contained in:
Zuul 2019-03-14 19:28:22 +00:00 committed by Gerrit Code Review
commit 8781ece44f
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
neutron/tests/unit/notifiers/test_nova.py
View File

@ -167,7 +167,7 @@ class TestNovaNotify(base.BaseTestCase):
event = self.nova_notifier.create_port_changed_event(
'create_floatingip', {}, returned_obj)
self.assertFalse(event, None)
self.assertIsNone(event)
def test_delete_floatingip_notify(self):
device_id = '32102d7b-1cf4-404d-b50a-97aae1f55f87'
@ -233,7 +233,7 @@ class TestNovaNotify(base.BaseTestCase):
'send_events') as send_events:
self.nova_notifier.send_network_change('update_floatingip',
{}, {})
self.assertFalse(send_events.called, False)
self.assertFalse(send_events.called)
@mock.patch('novaclient.client.Client')
def test_nova_send_events_returns_bad_list(self, mock_client):

2
neutron/tests/unit/services/placement_report/test_plugin.py
View File

@ -188,7 +188,7 @@ class PlacementReporterAgentsTestCases(test_plugin.Ml2PluginV2TestCase):
self.agents = plugin.PlacementReporterAgents(ml2_plugin=self.plugin)
mech_driver = self.agents.mechanism_driver_by_agent_type(
'test_mechanism_driver_agent')
self.assertTrue(mech_driver, mechanism_test.TestMechanismDriver)
self.assertIsInstance(mech_driver, mechanism_test.TestMechanismDriver)
def test_mechanism_driver_by_agent_type_not_found(self):
self.agents = plugin.PlacementReporterAgents(ml2_plugin=self.plugin)