openstack/neutron
Code Issues Proposed changes

Mock ls_get in OVN metadata delete network unit test

Browse Source 
"TypeError: 'Mock' object is not iterable" could possibly
be triggered by test_metadata_port_on_network_delete()
since there is a missing mock of the return value for ls_get.

Although I did not see the error described in the bug, I did
verify ls_get was returning an incorrect value by printing
it in the code, which after this patch was a fake row.

Change-Id: Ib1f204c98eee96321c7befebf94012dc2c80b1e8
Closes-bug: #1973731
This commit is contained in:
Brian Haley
2022-12-01 17:53:42 -05:00
parent 895f818cb3
commit 88b7db0e0c
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
neutron/tests/unit/plugins/ml2/drivers/ovn/mech_driver/test_mech_driver.py
View File

@@ -4094,6 +4094,9 @@ class TestOVNMechanismDriverMetadataPort(MechDriverSetupBase,
Check that the metadata port is deleted when a network is deleted.
"""
nb_idl = self.mech_driver._ovn_client._nb_idl
nb_idl.ls_get.return_value.execute.return_value = (
fakes.FakeOvsdbRow.create_one_ovsdb_row(attrs={'ports': []}))
net = self._make_network(self.fmt, name="net1", admin_state_up=True)
network_id = net['network']['id']
req = self.new_delete_request('networks', network_id)