openstack
/
neutron
Code Issues Proposed changes

Use is_valid_port from oslo.utils 

oslo.utils provides method is_valid_port to check port value.
Let's use it.

Change-Id: Ie858dc747b4dfb8f5bbacd43272180f077621745
This commit is contained in:
ChangBo Guo(gcb) 2016-06-08 14:56:59 +08:00
parent 036295895c
commit 8afc65ce3a
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
neutron/extensions/securitygroup.py
View File

@ -19,6 +19,7 @@ import netaddr
from neutron_lib.api import validators
from neutron_lib import constants as const
from neutron_lib import exceptions as nexception
from oslo_utils import netutils
from oslo_utils import uuidutils
import six
@ -175,13 +176,9 @@ def convert_ethertype_to_case_insensitive(value):
def convert_validate_port_value(port):
if port is None:
return port
try:
val = int(port)
except (ValueError, TypeError):
raise SecurityGroupInvalidPortValue(port=port)
if val >= 0 and val <= 65535:
return val
if netutils.is_valid_port(port):
return int(port)
else:
raise SecurityGroupInvalidPortValue(port=port)