From 74550b7b1517730c2e09b0edf9bb9131a7ba6542 Mon Sep 17 00:00:00 2001 From: Slawek Kaplonski Date: Tue, 1 Oct 2019 11:39:05 +0200 Subject: [PATCH] Code review policy - add note about approving mechanical changes It should be enough for most of "mechanical" changes to get +2 from only 1 core reviewer to approve patch. This patch adds such note to the Neutron's code review guidlines. Change-Id: I5ccdaa5a30337157933fcdee85252979da238a26 --- doc/source/contributor/policies/code-reviews.rst | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/doc/source/contributor/policies/code-reviews.rst b/doc/source/contributor/policies/code-reviews.rst index b4ef4939423..0ce48f03c5a 100644 --- a/doc/source/contributor/policies/code-reviews.rst +++ b/doc/source/contributor/policies/code-reviews.rst @@ -95,6 +95,11 @@ In addition to that, the following rules are to follow: ensure that correct HTTP error is returned when wrong data is provided, will be added where it is appropriate. +* It is usually enough for any "mechanical" changes, like e.g. translation + imports or imports of updated CI templates, to have only one +2 Code-Review + vote to be approved. If there is any uncertainty about a specific patch, it is + better to wait for review from another core reviewer before approving the patch. + .. _spec-review-practices: Neutron Spec Review Practices